Skip to content

[APM] Forbidden Error when opening Indices page with read only user#87147

Merged
cauemarcondes merged 2 commits intoelastic:masterfrom
cauemarcondes:apm-forbidden-error
Jan 4, 2021
Merged

[APM] Forbidden Error when opening Indices page with read only user#87147
cauemarcondes merged 2 commits intoelastic:masterfrom
cauemarcondes:apm-forbidden-error

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Jan 4, 2021

closes #87024

Before
Screenshot 2021-01-04 at 14 10 27

After
Screenshot 2021-01-04 at 14 10 05

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Jan 4, 2021
@cauemarcondes cauemarcondes requested a review from a team January 4, 2021 13:27
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jan 4, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte
Copy link
Copy Markdown
Contributor

ogupte commented Jan 4, 2021

Should we also disable the EuiFieldText for each of the indices?

'xpack.apm.settings.apmIndices.noPermissionTooltipLabel',
{
defaultMessage:
"Your user role doesn't have permissions to change APM indices",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@formgeist or @bmorelli25 any thoughts about this error message?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@cauemarcondes
Copy link
Copy Markdown
Contributor Author

Should we also disable the EuiFieldText for each of the indices?

Done! thanks for the suggestion.

Copy link
Copy Markdown
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +486.0B

Distributable file count

id before after diff
default 47264 48024 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit df1bfcc into elastic:master Jan 4, 2021
@cauemarcondes cauemarcondes deleted the apm-forbidden-error branch January 4, 2021 16:33
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jan 4, 2021
…lastic#87147)

* disabling create/edit button when user does not have write permission

* addressing PR comments
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jan 4, 2021
…lastic#87147)

* disabling create/edit button when user does not have write permission

* addressing PR comments
cauemarcondes added a commit that referenced this pull request Jan 4, 2021
…87147) (#87179)

* disabling create/edit button when user does not have write permission

* addressing PR comments
cauemarcondes added a commit that referenced this pull request Jan 4, 2021
…87147) (#87178)

* disabling create/edit button when user does not have write permission

* addressing PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Forbidden Error when opening Indices page with read only user

6 participants