Remove support for setting server.host to '0' (breaking)#87114
Merged
watson merged 3 commits intoelastic:masterfrom Jan 6, 2021
Merged
Remove support for setting server.host to '0' (breaking)#87114watson merged 3 commits intoelastic:masterfrom
watson merged 3 commits intoelastic:masterfrom
Conversation
This was referenced Jan 4, 2021
Contributor
Author
|
@graphaelli You mentioned that we list |
tylersmalley
reviewed
Jan 5, 2021
pgayvallet
approved these changes
Jan 5, 2021
jbudz
approved these changes
Jan 5, 2021
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
mshustov
reviewed
Jan 6, 2021
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 11, 2021
10 tasks
mdelapenya
added a commit
to elastic/e2e-testing
that referenced
this pull request
Jan 11, 2021
* fix: use proper server.host in Kibana See elastic/kibana#87114 * fix: switch to the official namespaces to consume upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for this was originally a side-effect of our old version of hapi (pre v20). hapi v20 does no longer support this, so a workaround was added to not break expectations. This PR removes that workaround for v8.0.0 as it's considered a breaking change.
Besides, in the new version of joi,
0is no longer considered a valid hostname, so when we upgrade, this extravalidatefunction can be removed.Todo
0as theirserver.host(Use 0.0.0.0 instead of 0 as server.host elastic-package#211)00??Release note
Removes support for configuring Kibana with
0as theserver.host.