Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix: use proper server.host in Kibana#576

Merged
mdelapenya merged 2 commits intoelastic:masterfrom
mdelapenya:575-fix-kibana-server-host
Jan 11, 2021
Merged

fix: use proper server.host in Kibana#576
mdelapenya merged 2 commits intoelastic:masterfrom
mdelapenya:575-fix-kibana-server-host

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented Jan 11, 2021 •
edited
Loading

See elastic/kibana#87114

What does this PR do?

It updates the e2e tests after elastic/kibana#87114

Why is it important?

Kibana fails to start and the container dies because of a wrong value of the server.host property.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • Kibana is able to start
  • The new value is a valid value according Kibana

How to test this PR locally

SUITE="fleet" TAGS="fleet_mode_agent && unenroll" DEVELOPER_MODE=true TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE make -C e2e functional-test

Related issues

@mdelapenya mdelapenya self-assigned this Jan 11, 2021
@mdelapenya mdelapenya requested review from a team and watson January 11, 2021 10:06
@mdelapenya mdelapenya marked this pull request as ready for review January 11, 2021 10:07
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 11, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #576 updated

  • Start Time: 2021-01-11T10:18:26.651+0000

  • Duration: 23 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 80
Skipped 12
Total 92

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 80
Skipped 12
Total 92

mdelapenya
mdelapenya commented Jan 11, 2021
View reviewed changes
cli/config/compose/profiles/fleet/docker-compose.yml
- ELASTIC_USERNAME=elastic
- ELASTIC_PASSWORD=changeme
image: "docker.elastic.co/observability-ci/elasticsearch:${stackVersion:-8.0.0-SNAPSHOT}"
image: "docker.elastic.co/elasticsearch/elasticsearch:${stackVersion:-8.0.0-SNAPSHOT}"
Copy link
Copy Markdown
Contributor Author

@mdelapenya mdelapenya Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're replacing the namespace because the observability-ci could not be up-to-date with latest SNAPSHOT, which is version we want to test in master. Consuming the upstream will allow us to discover potential bugs the soonest

@mdelapenya
Copy link
Copy Markdown
Contributor Author

mdelapenya commented Jan 11, 2021

BTW @watson, Does this change have to be backported to our 7.x or 7.11.x or 7.10.x branches? I guess not, as in the original Kibana PR it mentions it's for 8.0.0. Just to double check before merging. Thanks!

@watson
Copy link
Copy Markdown

watson commented Jan 11, 2021 •
edited
Loading

@mdelapenya No we consider it a breaking change, so it's only for v8.0.0. However, I did introduce another PR to 7.x which deprecates using 0: elastic/kibana#87471. But that will just output a warning in the logs. So as long as you don't care about that, it should be ok.

@mdelapenya
Copy link
Copy Markdown
Contributor Author

mdelapenya commented Jan 11, 2021

Thank you my friend!! Will merge this with no backport. Cheers!

@mdelapenya mdelapenya merged commit 27677e8 into elastic:master Jan 11, 2021
@mdelapenya mdelapenya deleted the 575-fix-kibana-server-host branch January 11, 2021 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@watson watson watson approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdelapenya mdelapenya

Labels

skip_backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Kibana's server host

4 participants

@mdelapenya @elasticmachine @watson @kuisathaverat