Expose anonymous access through a switch in sharing menu by streamich · Pull Request #86965 · elastic/kibana

streamich · 2020-12-28T13:24:06Z

Summary

See "Release note" below for more info.

How to test

To test this feature, you should add the following to your kibana.yml:

xpack.security.authc.providers:
  basic.basic1:
    order: 0
  anonymous.anonymous1:
    order: 1
    credentials:
      username: "anonymous"
      password: "anonymous"

Then you will need to create a Kibana user with username anonymous and password anonymous. You can also create a dedicated Kibana role for the anonymous user, in that role you need to give "read" access to anonymous user for Dashboard, Discover and Visualize apps; and you need to give that user also access to Kibana Index Patterns. And you should be able to create URLs that can be accessed anonymously.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

For maintainers

This was checked for breaking API changes and was labeled appropriately

Release note

Anonymous authentication feature is now exposed in Dashboard, Discover and Visualize apps in the sharing menu. If you enable an anonymous user with read access for Dashboard, Discover or Visualize apps you can create a sharing link which allows unauthenticated anonymous user to view those apps if you check "Public URL" switch in the sharing menu.

azasypkin · 2021-01-21T15:30:42Z

ACK: reviewing...

azasypkin

Did initial review pass, looks great! Left a few nits and questions.

src/plugins/security_oss/public/plugin.mock.ts

src/plugins/share/tsconfig.json

src/plugins/share/public/plugin.ts

src/plugins/share/public/types.ts

src/plugins/share/public/services/share_menu_manager.tsx

src/plugins/share/public/components/share_context_menu.tsx

src/plugins/share/public/components/url_panel_content.tsx

elasticmachine · 2021-01-25T10:25:19Z

Pinging @elastic/kibana-app-services (Team:AppServices)

azasypkin

LGTM from the security perspective, tested locally and everything seems to be working as expected, thanks!

I'm only not sure about the text for Public URL and hint, @arisonl is going to confirm that for us. But we can tune it at any time anyway.

src/plugins/discover/public/application/components/top_nav/get_top_nav_links.ts

src/plugins/share/public/components/url_panel_content.tsx

streamich · 2021-01-27T11:33:23Z

@elasticmachine merge upstream

clintandrewhall

Just a few nits. Thanks @streamich !

src/plugins/dashboard/public/application/top_nav/show_share_modal.tsx

src/plugins/visualize/public/application/utils/get_top_nav_config.tsx

streamich · 2021-01-28T08:53:17Z

@elasticmachine merge upstream

arisonl · 2021-01-28T11:00:54Z

@azasypkin @streamich Looks great, we should turn the hint message into something more generic than just dashboards. E.g.:
"Use public URL to share your [visualizations, dashboards and Discover] with anyone, [without requiring them to login]" or perhaps "Use public URL to share your [Kibana assets] with anyone. [It enables one-step access by removing the prompt to login or access as a guest]". Mix-and-match whatever is in brackets. @gchaps what do you think?

arisonl · 2021-01-28T11:03:03Z

Another idea would be to make this toggle available but disabled when anonymous access is not set up, so that we create awareness about the feature. The hint should be different in that case. By talking to @azasypkin this sounds like it is not of trivial effort, hence we can consider it later, if the need comes up. @streamich

flash1293

Kibana app changes LGTM - tested the feature and everything behaves as expected.

One nit:
The tooltip in the share menu talks about "the dashboard" - this is a bit confusing in discover and visualize. Can we change the wording to be more generic or pass in a configuration for this?

ppisljar

code LGTM

streamich · 2021-01-28T14:11:16Z

@arisonl @flash1293 I've adjusted the tooltip copy as suggested.

kibanamachine · 2021-01-28T15:46:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b3feb37

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	159.9KB	160.1KB	+223.0B
`discover`	412.8KB	413.0KB	+219.0B
`visualize`	97.5KB	97.7KB	+223.0B
total			+665.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`share`	69.9KB	73.2KB	+3.3KB

History

💚 Build #101716 succeeded cd22789
💔 Build #101693 failed 0d59c4a5a9c68f4139615b0c6cca30a398a0d26e
💔 Build #101468 failed a03f96e
💔 Build #101406 failed cc4686ec57b66aece57a089e1666fba5323eaa76
💚 Build #101370 succeeded 04b9d7a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gchaps · 2021-01-28T18:16:57Z

Based on what @arisonl said, my recommendation is:

Use Public URL to Share your visualizations, dashboards, and searches with anyone, without requiring them to log in.

I noticed that the tooltips for the Permalink link items are widely inconsistent. I'll file an issue with suggestions for improvements.

…9610) * feat: 🎸 add "Public URL" switch * feat: 🎸 add url subtitle * feat: 🎸 add public URL toggle state * feat: 🎸 allow to dynamically enable anonymous access switch * feat: 🎸 add anon access url parameters to share url * fix: 🐛 correctly add params to url * fix: 🐛 correctly add anon access to saved object URL * fix: 🐛 don't generate anon access urls twice * feat: 🎸 add ability to check anonymous user capabilities * feat: 🎸 add capability checks to Discover and Visualize apps * refactor: 💡 use early return * test: 💍 use security_oss mocks * feat: 🎸 add anon access url params to short url * test: 💍 fix jest snapshots * perf: ⚡️ make capabilities check synchronous * style: 💄 add stylistic review changes * perf: ⚡️ don't fetch anon user capabilities if anon not enabled * fix: 🐛 in discover app check if discover exists in capabilities * test: 💍 add tests for discover sharing check * test: 💍 add tests for showPublicUrlSwitch checks * feat: 🎸 make visualize capabilities props required * style: 💄 remove unused import * feat: 🎸 improve tooltip copy Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

feat: 🎸 add "Public URL" switch

8cdbb80

azasypkin mentioned this pull request Dec 31, 2020

Expose AnonymousAccess service through Security OSS plugin. #87091

Merged

streamich added 15 commits January 4, 2021 11:43

Merge remote-tracking branch 'upstream/master' into anon-access-switch

cb5d24b

Merge remote-tracking branch 'upstream/master' into anon-access-switch

2669231

feat: 🎸 add url subtitle

0ca6f01

feat: 🎸 add public URL toggle state

5e45d7b

Merge remote-tracking branch 'upstream/master' into anon-access-switch

f109e9c

feat: 🎸 allow to dynamically enable anonymous access switch

75e5d7f

feat: 🎸 add anon access url parameters to share url

db2a331

fix: 🐛 correctly add params to url

23908de

fix: 🐛 correctly add anon access to saved object URL

bb1a13b

fix: 🐛 don't generate anon access urls twice

f9fe897

feat: 🎸 add ability to check anonymous user capabilities

d94e021

feat: 🎸 add capability checks to Discover and Visualize apps

5814f6e

refactor: 💡 use early return

0f209f0

Merge remote-tracking branch 'upstream/master' into anon-access-switch

1ac6a6e

test: 💍 use security_oss mocks

a9ded2a

streamich changed the title ~~feat: 🎸 add "Public URL" switch~~ Expose anonymous access through a switch in sharing menu Jan 21, 2021

streamich added 2 commits January 21, 2021 11:20

feat: 🎸 add anon access url params to short url

a319a04

test: 💍 fix jest snapshots

4a3f22f

streamich marked this pull request as ready for review January 21, 2021 12:13

streamich requested a review from a team January 21, 2021 12:13

streamich requested review from a team as code owners January 21, 2021 12:13

streamich requested review from azasypkin and ppisljar January 21, 2021 12:13

azasypkin reviewed Jan 21, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into anon-access-switch

cd851c7

streamich added release_note:enhancement review Team:AppServices v7.12.0 v8.0.0 labels Jan 25, 2021

azasypkin approved these changes Jan 26, 2021

View reviewed changes

src/plugins/discover/public/application/components/top_nav/get_top_nav_links.ts Outdated Show resolved Hide resolved

src/plugins/share/public/components/url_panel_content.tsx Outdated Show resolved Hide resolved

streamich added 4 commits January 27, 2021 09:42

Merge remote-tracking branch 'upstream/master' into anon-access-switch

1cd1349

fix: 🐛 in discover app check if discover exists in capabilities

04b9d7a

test: 💍 add tests for discover sharing check

37a3631

test: 💍 add tests for showPublicUrlSwitch checks

511e917

clintandrewhall approved these changes Jan 27, 2021

View reviewed changes

streamich added 2 commits January 27, 2021 16:52

Merge remote-tracking branch 'upstream/master' into anon-access-switch

325f171

feat: 🎸 make visualize capabilities props required

a03f96e

streamich added 2 commits January 28, 2021 11:49

style: 💄 remove unused import

fe5e677

Merge remote-tracking branch 'upstream/master' into anon-access-switch

cd22789

flash1293 approved these changes Jan 28, 2021

View reviewed changes

ppisljar approved these changes Jan 28, 2021

View reviewed changes

feat: 🎸 improve tooltip copy

b3feb37

streamich merged commit 10e6354 into elastic:master Jan 28, 2021

streamich mentioned this pull request Jan 28, 2021

[7.x] Expose anonymous access through a switch in sharing menu (#86965) #89610

Merged

azasypkin mentioned this pull request Feb 5, 2021

Simplify anonymous access & embedding docs. #90409

Merged

Conversation

streamich commented Dec 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Checklist

For maintainers

Release note

Uh oh!

azasypkin commented Jan 21, 2021

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Jan 25, 2021

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

streamich commented Jan 27, 2021

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

streamich commented Jan 28, 2021

Uh oh!

arisonl commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arisonl commented Jan 28, 2021

Uh oh!

flash1293 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

streamich commented Jan 28, 2021

Uh oh!

kibanamachine commented Jan 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

gchaps commented Jan 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

streamich commented Dec 28, 2020 •

edited

Loading

arisonl commented Jan 28, 2021 •

edited

Loading

flash1293 left a comment •

edited

Loading