Skip to content

[7.x] Expose anonymous access through a switch in sharing menu (#86965)#89610

Merged
streamich merged 4 commits intoelastic:7.xfrom
streamich:backport/7.x/pr-86965
Jan 30, 2021
Merged

[7.x] Expose anonymous access through a switch in sharing menu (#86965)#89610
streamich merged 4 commits intoelastic:7.xfrom
streamich:backport/7.x/pr-86965

Conversation

@streamich
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* feat: 🎸 add "Public URL" switch

* feat: 🎸 add url subtitle

* feat: 🎸 add public URL toggle state

* feat: 🎸 allow to dynamically enable anonymous access switch

* feat: 🎸 add anon access url parameters to share url

* fix: 🐛 correctly add params to url

* fix: 🐛 correctly add anon access to saved object URL

* fix: 🐛 don't generate anon access urls twice

* feat: 🎸 add ability to check anonymous user capabilities

* feat: 🎸 add capability checks to Discover and Visualize apps

* refactor: 💡 use early return

* test: 💍 use security_oss mocks

* feat: 🎸 add anon access url params to short url

* test: 💍 fix jest snapshots

* perf: ⚡️ make capabilities check synchronous

* style: 💄 add stylistic review changes

* perf: ⚡️ don't fetch anon user capabilities if anon not enabled

* fix: 🐛 in discover app check if discover exists in capabilities

* test: 💍 add tests for discover sharing check

* test: 💍 add tests for showPublicUrlSwitch checks

* feat: 🎸 make visualize capabilities props required

* style: 💄 remove unused import

* feat: 🎸 improve tooltip copy
@streamich streamich added the backport This PR is a backport of another PR label Jan 28, 2021
@streamich
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@streamich
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@streamich
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 160.8KB 161.0KB +223.0B
discover 415.1KB 415.3KB +219.0B
visualize 98.6KB 98.8KB +223.0B
total +665.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 70.1KB 73.3KB +3.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit d231cb1 into elastic:7.x Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants