[Security Solutions] fix timeline tabs + layout#86581
Merged
XavierM merged 4 commits intoelastic:masterfrom Dec 19, 2020
Merged
[Security Solutions] fix timeline tabs + layout#86581XavierM merged 4 commits intoelastic:masterfrom
XavierM merged 4 commits intoelastic:masterfrom
Conversation
x-pack/plugins/watcher/server/lib/fetch_all_from_scroll/index.ts~HEAD
Outdated
Show resolved
Hide resolved
...s/watcher/server/lib/fetch_all_from_scroll/index.ts~e4bcb05f652a72b1153de94f6f72d9d03da2a4b5
Outdated
Show resolved
Hide resolved
...ns/security_solution/public/timelines/components/timeline/body/data_driven_columns/index.tsx
Outdated
Show resolved
Hide resolved
andrew-goldstein
approved these changes
Dec 19, 2020
Contributor
andrew-goldstein
left a comment
There was a problem hiding this comment.
Thanks for these fixes @XavierM! 🙏
Tested locally with the suggested changes
LGTM 🚀
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Dec 19, 2020
* fix timeline tabs + fix screenreader * review * fix jest tests
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Dec 19, 2020
* fix timeline tabs + fix screenreader * review * fix jest tests
XavierM
added a commit
that referenced
this pull request
Dec 20, 2020
XavierM
added a commit
that referenced
this pull request
Dec 20, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 21, 2020
* master: (48 commits) Fix request with disabled aggregation (elastic#85696) [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918) Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236) Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593) [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370) [Security Solutions] fix timeline tabs + layout (elastic#86581) Upgrade to hapi version 20 (elastic#85406) App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791) Rename chartLibrary setting to legacyChartsLibrary (elastic#86529) [CI] TeamCity updates (elastic#85843) [Maps] Use Json for mvt-tests (elastic#86492) [Rollup Jobs] Added autofocus to cron editor (elastic#86324) [Monitoring][Alerting] CCR read exceptions alert (elastic#85908) [CI] Bump memory for main CI workers (elastic#86541) Explicitly set Elasticsearch heap size during CI and local development (elastic#86513) [App Search] Updates to results on the documents view (elastic#86181) [Discover] Change default sort handling (elastic#85561) [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508) [App Search] Sample Engines should have access to the Crawler (elastic#86502) Fixed duplication of create new modal (elastic#86489) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist