[index patterns] Fleep app - Keep saved object field list until field caps provides fields#85370
Merged
mattkime merged 29 commits intoelastic:masterfrom Dec 20, 2020
Conversation
neptunian
reviewed
Dec 9, 2020
src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
Contributor
|
@jonathan-buttner do you think the failing endpoint test is related to our changes? |
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
neptunian
approved these changes
Dec 16, 2020
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jonathan-buttner
approved these changes
Dec 16, 2020
Contributor
jonathan-buttner
left a comment
There was a problem hiding this comment.
Endpoint changes LGTM ;)
…st_until_field_caps_sees_fields
….com:mattkime/kibana into keep_field_list_until_field_caps_sees_fields
lukeelmers
approved these changes
Dec 18, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresX-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/network_policy·ts.Reporting APIs Network Policy should fail job when page voilates the network policyStandard OutStack TraceMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Dec 20, 2020
… caps provides fields (elastic#85370)
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Dec 20, 2020
… caps provides fields (elastic#85370) # Conflicts: # src/plugins/data/public/public.api.md
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 21, 2020
* master: (48 commits) Fix request with disabled aggregation (elastic#85696) [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918) Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236) Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593) [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370) [Security Solutions] fix timeline tabs + layout (elastic#86581) Upgrade to hapi version 20 (elastic#85406) App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791) Rename chartLibrary setting to legacyChartsLibrary (elastic#86529) [CI] TeamCity updates (elastic#85843) [Maps] Use Json for mvt-tests (elastic#86492) [Rollup Jobs] Added autofocus to cron editor (elastic#86324) [Monitoring][Alerting] CCR read exceptions alert (elastic#85908) [CI] Bump memory for main CI workers (elastic#86541) Explicitly set Elasticsearch heap size during CI and local development (elastic#86513) [App Search] Updates to results on the documents view (elastic#86181) [Discover] Change default sort handling (elastic#85561) [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508) [App Search] Sample Engines should have access to the Crawler (elastic#86502) Fixed duplication of create new modal (elastic#86489) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Fleet app needs an index pattern field list to exist before documents do so that the dashboards it installs don't show errors before there's data. It provides a field list via the index pattern saved object. Index patterns need to use it until field caps provides a complete response.
Plans
logs-*andmetrics-*index patterns provided by Fleet will have a flag that will ignore field caps 404 errors.metrics-*andlogs-*Checklist
Delete any items that are not applicable to this PR.