align cors settings names with elasticsearch#85738
Merged
mshustov merged 2 commits intoelastic:masterfrom Dec 14, 2020
Merged
Conversation
pgayvallet
approved these changes
Dec 14, 2020
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Dec 14, 2020
* align cors settings names with elasticsearch * server.cors.origin: * --> server.cors.origin: ["*"]
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 14, 2020
* master: (116 commits) Fix UX E2E tests (elastic#85722) Increasing default api key removalDelay to 1h (elastic#85576) align cors settings names with elasticsearch (elastic#85738) unskip tests and make sure submit is not triggered too quickly (elastic#85567) Row trigger 2 (elastic#83167) Add session id to audit log (elastic#85451) [TSVB] Fields lists do not populate all the times (elastic#85530) [Visualize] Removes the external link icon from OSS badges (elastic#85580) fixes EQL tests (elastic#85712) [APM] enable 'log_level' for Go (elastic#85511) ini `1.3.5` -> `1.3.7` (elastic#85707) Fix fleet route protections (elastic#85626) [Monitoring] Some progress on making alerts better in the UI (elastic#81569) [Security Solution] Refactor Timeline Notes to use EuiCommentList (elastic#85256) [Security Solution][Detections][Threshold Rules] Threshold rule exceptions (elastic#85103) [Security Solution] Alerts details (elastic#83963) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) skip flaky suite (elastic#84020) skip flaky suite (elastic#85671) ...
mshustov
added a commit
that referenced
this pull request
Dec 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#84316 introduced CORS support with settings:
however Elasticsearch uses a bit different naming schema:
See https://github.com/elastic/elasticsearch/blob/f8c013d0fbb4ac55141891a56282f8b636aea62c/docs/reference/modules/http.asciidoc
We should align the naming across the stack.
Note: we don't use the
kebab-casenaming schema for the settings.Based on this comment [Discuss] API naming convention #52284 (comment) I'm renaming
server.cors.credentialstoserver.cors.allowCredentials;server.cors.origintoserver.cors.allowOrigin.I'd expect we rename (to use snake_case) the settings in both Kibana and Elasticsearch during Settings should use snake_case #7444
we should align schema across the stack.
server.cors.allowOrigin: '*'is refactored to beserver.cors.allowOrigin: ["*"]Plugin API changes
I'm going to update the docs in #84316