Skip to content

[TSVB] Fields lists do not populate all the times#85530

Merged
alexwizp merged 1 commit intoelastic:masterfrom
alexwizp:85411
Dec 14, 2020
Merged

[TSVB] Fields lists do not populate all the times#85530
alexwizp merged 1 commit intoelastic:masterfrom
alexwizp:85411

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Dec 10, 2020 •
edited
Loading

Closes: #85411

Describe the bug:
There are some occasions that the fields list and the time fields options don't populate.
Screenshot 2020-12-09 at 3 34 10 PM

Screenshot 2020-12-09 at 3 34 25 PM

I have tried to unskip the TSVB functional tests and this test https://github.com/elastic/kibana/blob/master/test/functional/apps/visualize/_tsvb_chart.ts#L133 fails a lot because the options on the list are not loaded.

Steps to reproduce:

  1. Create a new TSVB chart
  2. Change the default index pattern to another one
  3. The time fields list options don't appear

This doesn't happen always but it happens a lot. Moreover it is a blocker to unskip the TSVB chart functional tests.

Expected behavior:
Fields should always appear on the list.

@alexwizp alexwizp requested a review from VladLasitsa December 10, 2020 10:42
@alexwizp alexwizp self-assigned this Dec 10, 2020
@alexwizp alexwizp added v7.11.0 v8.0.0 Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Dec 10, 2020
@alexwizp alexwizp requested a review from stratoula December 10, 2020 11:03
@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Dec 10, 2020

I have run the flaky test runner 42 times https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1047/ and it doesn't fail but why this expect(newValue).to.eql('18') fails? I think it worked with this value in the past

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Dec 10, 2020

@stratoula I'm 95% sure the reason for this can be found here #83628. Before we used hardcoded value of 100 buckets but now for auto mode we use 2 props: histogram:maxBars and histogram:barTarget . Default value for last one is 50.

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Dec 10, 2020

@elasticmachine merge upstream

@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Dec 10, 2020

Yes this makes sense 😉

@alexwizp alexwizp marked this pull request as ready for review December 11, 2020 11:19
@alexwizp alexwizp requested a review from a team December 11, 2020 11:19
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 11, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Dec 14, 2020

@elasticmachine merge upstream

stratoula
stratoula approved these changes Dec 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have tested it locally and now the fields are populated. Let's keep the functional test skipped (revert these changes) as this suite is unstable and I will take care of all the problems on a second PR

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 14, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.8MB 1.8MB -82.0B

Distributable file count

id before after diff
default 47129 47889 +760

History

  • 💚 Build #93502 succeeded 63a63ed0850f332cb111b0952cc77ace8fc74b91
  • 💔 Build #93441 failed 504f0d4d982536c17d97d5c72aafbeab99c10c2e
  • 💔 Build #93425 failed 28752b5678d6db153c7625314eebcf2796f52fdb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 3f7f0be into elastic:master Dec 14, 2020
@alexwizp alexwizp mentioned this pull request Dec 14, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Dec 14, 2020
@alexwizp
[TSVB] Fields lists do not populate all the times (elastic#85530)
61042e1
alexwizp added a commit that referenced this pull request Dec 14, 2020
@alexwizp
[TSVB] Fields lists do not populate all the times (#85530) (#85751)
f95df73
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 14, 2020
@gmmorris
Merge branch 'master' into alerts/examples-plugin-broke
dbbe459 
* master: (116 commits)
  Fix UX E2E tests (elastic#85722)
  Increasing default api key removalDelay to 1h (elastic#85576)
  align cors settings names with elasticsearch (elastic#85738)
  unskip tests and make sure submit is not triggered too quickly (elastic#85567)
  Row trigger 2 (elastic#83167)
  Add session id to audit log (elastic#85451)
  [TSVB] Fields lists do not populate all the times (elastic#85530)
  [Visualize] Removes the external link icon from OSS badges (elastic#85580)
  fixes EQL tests (elastic#85712)
  [APM] enable 'log_level' for Go (elastic#85511)
  ini `1.3.5` -> `1.3.7` (elastic#85707)
  Fix fleet route protections (elastic#85626)
  [Monitoring] Some progress on making alerts better in the UI (elastic#81569)
  [Security Solution] Refactor Timeline Notes to use EuiCommentList (elastic#85256)
  [Security Solution][Detections][Threshold Rules] Threshold rule exceptions (elastic#85103)
  [Security Solution] Alerts details (elastic#83963)
  skip flaky suite (elastic#62060)
  skip flaky suite (elastic#85098)
  skip flaky suite (elastic#84020)
  skip flaky suite (elastic#85671)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@alexwizp alexwizp

Labels

Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TSVB] Fields lists do not populate all the times

4 participants

@alexwizp @stratoula @elasticmachine @kibanamachine