Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0#84768
Merged
DianaDerevyankina merged 5 commits intoelastic:masterfrom Dec 15, 2020
Merged
Conversation
…e Kibana 7.10.0 Closes elastic#84191
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
sulemanof
approved these changes
Dec 3, 2020
Contributor
sulemanof
left a comment
There was a problem hiding this comment.
LGTM 👍
Tested locally, works as expected both for gauge and goal visualizations!
I noticed such a weird overlapping in gauge vis.. Are you able reproduce the same locally?
src/plugins/vis_type_vislib/public/vislib/visualizations/gauge_chart.js
I used kibana_sample_data_ecommerce index, split by Terms - category.keyword.
And I actually expect to see 5 gauges of each category, but see only 2. Seems to be bug!
Could you please check? If it is, an issue is worth to be created!
Contributor
|
@sulemanof I can't reproduce it locally @dziyanadzeraviankina thanx for this PR! It seems to work great but can you also add a functional test about this? It seems that we don't test filtering on gauge and it will be good to have it. |
stratoula
approved these changes
Dec 14, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
LGTM, thanx @dziyanadzeraviankina for the functional test, it looks great now ❤️
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to ymao1/kibana
that referenced
this pull request
Dec 15, 2020
* master: (66 commits) [Alerting] fixes broken Alerting Example plugin (elastic#85774) [APM] Service overview instances table (elastic#85770) [Security Solution] Unskip timeline creation Cypress test (elastic#85871) properly recognize enterprise licenses (elastic#85849) [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690) [TSVB] Fix functional tests flakiness and unskip them (elastic#85388) [Fleet] Change permissions for Fleet enroll role (elastic#85802) Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768) [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488) [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424) skip flaky suite (elastic#78553) License checks for alerts plugin (elastic#85649) skip flaky suite (elastic#84992) skip 'query return results valid for scripted field' elastic#78553 Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919) [ML] More machine learning links in doc_links_service.ts (elastic#85365) Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652) Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859) Fix outdated jest snapshot [Maps] Surface on prem EMS (elastic#85729) ...
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Dec 15, 2020
…e Kibana 7.10.0 (elastic#84768) * Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 Closes elastic#84191 * Add functional test to filtering on gauge
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Dec 15, 2020
…e Kibana 7.10.0 (elastic#84768) * Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 Closes elastic#84191 * Add functional test to filtering on gauge
alexwizp
added a commit
that referenced
this pull request
Dec 16, 2020
…e Kibana 7.10.0 (#84768) (#85938) * Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 Closes #84191 * Add functional test to filtering on gauge Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84191
Summary
Fixed filtering by click on split gauge visualizations:
Checklist
For maintainers