Query string input - load index patterns instead of saved objects#84457
Merged
mattkime merged 15 commits intoelastic:masterfrom Dec 6, 2020
Merged
Query string input - load index patterns instead of saved objects#84457mattkime merged 15 commits intoelastic:masterfrom
mattkime merged 15 commits intoelastic:masterfrom
Conversation
8 tasks
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
Contributor
|
how is this related to #84458 ? |
lizozom
reviewed
Nov 30, 2020
| return this.savedObjectsCache; | ||
| }; | ||
|
|
||
| find = async (search: string, size: number = 10): Promise<IndexPattern[]> => { |
Contributor
There was a problem hiding this comment.
Should we add a unit test for this function?
| const getIndexPatternPromises = savedObjects.map(async (savedObject) => { | ||
| return await this.get(savedObject.id); | ||
| }); | ||
| return await Promise.all(getIndexPatternPromises); |
Contributor
There was a problem hiding this comment.
//nit isn't the await redundant?
Contributor
Author
|
@ppisljar Same problem in a different spot in the codebase. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Dec 6, 2020
…astic#84457) * load index patterns instead of saved objects * remove getFromSavedObject * add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to - #84352
Use index pattern service to load index pattern instance instead of loading saved object and transforming into index pattern like object. This correctly loads the field list.