[visualizations] get index pattern via service instead of saved object#84458
Merged
mattkime merged 5 commits intoelastic:masterfrom Nov 30, 2020
Merged
Conversation
8 tasks
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
stratoula
approved these changes
Nov 30, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Code LGTM, tested it locally and works as expected
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Dec 2, 2020
elastic#84458) * embeddable - get index pattern via service instead of saved object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#82223 - stopped caching fields in the index pattern field list.
Use index pattern service and load index pattern instance instead of getting saved object and transforming into index pattern like object.