[ILM] Add shrink field to hot phase by jloleysens · Pull Request #84087 · elastic/kibana

jloleysens · 2020-11-23T14:20:31Z

Summary

Fix #82879

How to test

Start kibana and go to the index lifecycle management section in the management section
Create a new ILM policy configuring both shrink actions in hot and warm (you will need to activate warm)
Check the policy JSON in the flyout, we should have configuration for shrink in both hot and warm
Save the policy
Return to the policy and make sure the settings that were set before are presented in the same way

Open questions

Do we want to warn users about configuring a shrink action in warm that has a higher number than in hot?

Screenshots

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-11-23T14:20:33Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

...management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts

yuliacech · 2020-11-23T16:12:52Z

...ent/public/application/sections/edit_policy/components/phases/shared_fields/shrink_field.tsx

+            id="xpack.indexLifecycleMgmt.editPolicy.shrinkIndexExplanationText"
+            defaultMessage="Shrink the index into a new index with fewer primary shards."
+          />{' '}
+          <LearnMoreLink docPath="indices-shrink-index.html#indices-shrink-index" />


I know the docs link was there before, but this page seems to work better for this context, wdyt?
https://www.elastic.co/guide/en/elasticsearch/reference/master/ilm-shrink.html

yuliacech

Hi @jloleysens , nice work adding shrink support to hot phase! I tested locally and the policy editor worked. I have only 2 suggestions to improve in this PR but not blocking:

I noticed that shared fields have inconsistent names: Forcemerge, SetPriorityInput, MinAgeInputField, ShrinkField. I think it would make sense to keep a consistent naming convention, for example have everything end with Field since also files are named this way.
To your open question: I think it would make sense to at least warn the user about warm phase having a larger number of shards than hot phase. I tested with an index starting with 5 shards, hot phase shrinks to 1 shard and then warm phase fails while trying to 'shrink' to 5 shards (see attached screenshot).

…k-field-to-hot-phase * 'master' of github.com:elastic/kibana: (429 commits) simplify popover open state logic (elastic#85379) [Logs UI][Metrics UI] Move actions to the kibana header (elastic#84648) [Search Source] Do not pick scripted fields if * provided (elastic#85133) [Search] Session SO polling (elastic#84225) [Transform] Replace legacy elasticsearch client (elastic#84932) [Uptime]Refactor header and action menu (elastic#83779) Fix agg select external link (elastic#85380) [ILM] Show forcemerge in hot when rollover is searchable snapshot is enabled (elastic#85292) clear using keyboard (elastic#85042) [GS] add tag and dashboard suggestion results (elastic#85144) [ML] API integration tests - skip GetAnomaliesTableData Add ECS field for event.code. (elastic#85109) [Functional][TSVB] Wait for markdown textarea to be cleaned (elastic#85128) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) Bump highlight.js to v9.18.5 (elastic#84296) Add `server.publicBaseUrl` config (elastic#85075) [Alerting & Actions ] More debug logging (elastic#85149) [Security Solution][Case] Manual attach alert to a case (elastic#82996) Loosen UUID regex to accept uuidv1 or uuidv4 (elastic#85338) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts # x-pack/plugins/index_lifecycle_management/server/routes/api/policies/register_create_route.ts

…fields in hot phase advanced

yuliacech · 2020-12-09T17:26:35Z

Hi @jloleysens , I had a look at your updates to this PR since the last review and changes LGTM!
I'll create an issue for UX improvements of shrink action to keep track of:

warn the user when warm phase has a larger number of shards then the hot phase
add a help text to the input field that the number of shards needs to be a factor of the number of the existing shards

Anyways, I'm good with merging this when CI is green! 🎉

* moved shrink field to shared_fields and added it to the hot phase * updated test * update legacy jest test * removed configuration context for now * remove unused i18n and remove duplicated isRolloverEnabled check; * fixed shrink field to use new described field component * added test for removing shrink field in serialization and re-ordered fields in hot phase advanced

* master: (53 commits) Fixing recovered instance reference bug (elastic#85412) Switch to new elasticsearch client for Visualizations (elastic#85245) Switch to new elasticsearch client for TSVB (elastic#85275) Switch to new elasticsearch client for Vega (elastic#85280) [ILM] Add shrink field to hot phase (elastic#84087) Add rolling-file appender to core logging (elastic#84735) [APM] Service overview: Dependencies table (elastic#83416) [Uptime ]Update empty message for certs list (elastic#78575) [Graph] Fix graph saved object references (elastic#85295) [APM] Create new API's to return Latency and Throughput charts (elastic#85242) [Advanced settings] Reset to default for empty strings (elastic#85137) [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (elastic#83761) [Fleet] Update agent listing for better status reporting (elastic#84798) [APM] enable 'sanitize_field_names' for Go (elastic#85373) Update dependency @elastic/charts to v24.4.0 (elastic#85452) Introduce external url service (elastic#81234) Deprecate disabling the security plugin (elastic#85159) [FLEET] New Integration Policy Details page for use in Integrations section (elastic#85355) [Security Solutions][Detection Engine] Fixes one liner access control with find_rules REST API chore: 🤖 remove extraPublicDirs (elastic#85454) ...

* moved shrink field to shared_fields and added it to the hot phase * updated test * update legacy jest test * removed configuration context for now * remove unused i18n and remove duplicated isRolloverEnabled check; * fixed shrink field to use new described field component * added test for removing shrink field in serialization and re-ordered fields in hot phase advanced

kibanamachine · 2020-12-10T17:19:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3b09eb1

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`indexLifecycleManagement`	138	139	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`indexLifecycleManagement`	244.2KB	245.2KB	+963.0B

Distributable file count

id	before	after	diff
`default`	46981	47741	+760

History

💚 Build #93121 succeeded 3b09eb1
💔 Build #93105 failed 0e2c525
💚 Build #89656 succeeded 9bceac5
💔 Build #89624 failed fb011fa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens added 4 commits November 23, 2020 15:04

moved shrink field to shared_fields and added it to the hot phase

bc208d6

updated test

0a1d9e7

update legacy jest test

6d11a4e

removed configuration context for now

fb011fa

jloleysens added release_note:enhancement Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.11.0 labels Nov 23, 2020

jloleysens requested a review from yuliacech November 23, 2020 14:20

jloleysens requested a review from a team as a code owner November 23, 2020 14:20

yuliacech reviewed Nov 23, 2020

View reviewed changes

...management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx Outdated Show resolved Hide resolved

yuliacech reviewed Nov 23, 2020

View reviewed changes

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts Outdated Show resolved Hide resolved

remove unused i18n and remove duplicated isRolloverEnabled check;

9bceac5

yuliacech reviewed Nov 23, 2020

View reviewed changes

yuliacech approved these changes Nov 23, 2020

View reviewed changes

jloleysens added 3 commits December 9, 2020 15:22

fixed shrink field to use new described field component

1f28720

added test for removing shrink field in serialization and re-ordered …

3b09eb1

…fields in hot phase advanced

yuliacech mentioned this pull request Dec 9, 2020

[ILM] Warn user when shrink action has more shards in warm phase #85443

Closed

jloleysens merged commit dbd14ad into elastic:master Dec 10, 2020

jloleysens deleted the ilm/add-shrink-field-to-hot-phase branch December 10, 2020 09:50

jloleysens mentioned this pull request Dec 10, 2020

[7.x] [ILM] Add shrink field to hot phase (#84087) #85525

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ILM] Add shrink field to hot phase#84087

[ILM] Add shrink field to hot phase#84087
jloleysens merged 8 commits intoelastic:masterfrom
jloleysens:ilm/add-shrink-field-to-hot-phase

jloleysens commented Nov 23, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Nov 23, 2020

Uh oh!

Uh oh!

Uh oh!

yuliacech Nov 23, 2020

Uh oh!

yuliacech left a comment

Uh oh!

yuliacech commented Dec 9, 2020

Uh oh!

kibanamachine commented Dec 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jloleysens commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Open questions

Screenshots

Checklist

Uh oh!

elasticmachine commented Nov 23, 2020

Uh oh!

Uh oh!

Uh oh!

yuliacech Nov 23, 2020

Choose a reason for hiding this comment

Uh oh!

yuliacech left a comment

Choose a reason for hiding this comment

Uh oh!

yuliacech commented Dec 9, 2020

Uh oh!

kibanamachine commented Dec 10, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jloleysens commented Nov 23, 2020 •

edited

Loading