[Security Solution][Case] Manual attach alert to a case#82996
Merged
cnasikas merged 17 commits intoelastic:masterfrom Dec 8, 2020
Merged
[Security Solution][Case] Manual attach alert to a case#82996cnasikas merged 17 commits intoelastic:masterfrom
cnasikas merged 17 commits intoelastic:masterfrom
Conversation
0d763eb to
4788048
Compare
b8f1ecd to
c8e55c8
Compare
c8e55c8 to
1249e47
Compare
6be47ae to
47b15f9
Compare
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/index.tsx
Outdated
Show resolved
Hide resolved
...y_solution/public/detections/components/alerts_table/timeline_actions/alert_context_menu.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/use_all_cases_modal/index.test.tsx
Outdated
Show resolved
Hide resolved
f13f32f to
370198f
Compare
4962659 to
241765d
Compare
stephmilovic
reviewed
Dec 7, 2020
x-pack/plugins/security_solution/public/cases/containers/use_post_comment.tsx
Outdated
Show resolved
Hide resolved
stephmilovic
reviewed
Dec 7, 2020
x-pack/plugins/security_solution/public/cases/containers/use_post_comment.tsx
Show resolved
Hide resolved
XavierM
reviewed
Dec 7, 2020
x-pack/plugins/security_solution/public/cases/components/add_comment/index.tsx
Show resolved
Hide resolved
XavierM
reviewed
Dec 7, 2020
x-pack/plugins/security_solution/public/cases/components/all_cases/index.tsx
Show resolved
Hide resolved
XavierM
reviewed
Dec 7, 2020
x-pack/plugins/security_solution/public/cases/components/all_cases/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 7, 2020
x-pack/plugins/security_solution/public/cases/components/use_create_case_modal/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 7, 2020
x-pack/plugins/security_solution/public/cases/components/use_create_case_modal/index.tsx
Show resolved
Hide resolved
XavierM
requested changes
Dec 7, 2020
Contributor
XavierM
left a comment
There was a problem hiding this comment.
I do feel like the unit tests that you deleted are still valid and should stay in the repo.
Member
Author
Thanks! Which ones? |
df9b83f to
812de1e
Compare
XavierM
reviewed
Dec 8, 2020
...ck/plugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Dec 8, 2020
...ck/plugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.tsx
Outdated
Show resolved
Hide resolved
0119c64 to
93ba1af
Compare
XavierM
approved these changes
Dec 8, 2020
7080db3 to
39c42f0
Compare
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Dec 8, 2020
cnasikas
added a commit
that referenced
this pull request
Dec 9, 2020
Contributor
💔 Build Failed
Failed CI StepsTest FailuresX-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/results/get_anomalies_table_data·ts.apis Machine Learning ResultsService GetAnomaliesTableData should fetch anomalies table dataStandard OutStack TraceX-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/results/get_anomalies_table_data·ts.apis Machine Learning ResultsService GetAnomaliesTableData should fetch anomalies table dataStandard OutStack TraceMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 9, 2020
…k-field-to-hot-phase * 'master' of github.com:elastic/kibana: (429 commits) simplify popover open state logic (elastic#85379) [Logs UI][Metrics UI] Move actions to the kibana header (elastic#84648) [Search Source] Do not pick scripted fields if * provided (elastic#85133) [Search] Session SO polling (elastic#84225) [Transform] Replace legacy elasticsearch client (elastic#84932) [Uptime]Refactor header and action menu (elastic#83779) Fix agg select external link (elastic#85380) [ILM] Show forcemerge in hot when rollover is searchable snapshot is enabled (elastic#85292) clear using keyboard (elastic#85042) [GS] add tag and dashboard suggestion results (elastic#85144) [ML] API integration tests - skip GetAnomaliesTableData Add ECS field for event.code. (elastic#85109) [Functional][TSVB] Wait for markdown textarea to be cleaned (elastic#85128) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) Bump highlight.js to v9.18.5 (elastic#84296) Add `server.publicBaseUrl` config (elastic#85075) [Alerting & Actions ] More debug logging (elastic#85149) [Security Solution][Case] Manual attach alert to a case (elastic#82996) Loosen UUID regex to accept uuidv1 or uuidv4 (elastic#85338) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts # x-pack/plugins/index_lifecycle_management/server/routes/api/policies/register_create_route.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a feature in which a user can attach an alert to a case from the detection's engine alerts table. The user can either create a new case or select an existing case when attaching the alert.
Technical details:
usePostCommenthook does not take thecaseIdas an argument anymore.postCommentfunction takes an extra argumentcaseId.onRowClickfunction has been moved outside ofuseAllCasesModalhook.all_cases_modalfolder has been deleted.Attach to a new case:
Attach to an existing case:
Depends on: #82405
Checklist
Delete any items that are not applicable to this PR.
For maintainers