[Alerting] Add `alert.updatedAt` field to represent date of last user edit by ymao1 · Pull Request #83578 · elastic/kibana

ymao1 · 2020-11-17T19:34:16Z

Resolves #82701

Summary

Adds updatedAt field to the alert saved object that is updated when a user acts on an alert (updates the name or parameters or mutes/unmutes or enable/disables).

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…ing/updated-at

elasticmachine · 2020-11-18T00:22:59Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

dhurley14

LGTM! tested out the fix locally and everything looks good! Thanks!

gmmorris

LGTM, looks like you've covered all the bases :)

x-pack/plugins/alerts/server/alerts_client/alerts_client.ts

gmmorris · 2020-11-18T16:54:51Z

x-pack/plugins/alerts/server/saved_objects/migrations.test.ts

+  test('add updatedAt field to alert - set to createdAt when SavedObject updated_at is not defined', () => {
+    const migration711 = getMigrations(encryptedSavedObjectsSetup)['7.11.0'];
+    const alert = getMockData({});
+    expect(migration711(alert, { log })).toEqual({
+      ...alert,
+      attributes: {
+        ...alert.attributes,
+        updatedAt: alert.attributes.createdAt,
+      },
+    });
+  });
+});


Good catch! I would have totally missed that 😆

…ing/updated-at

kibanamachine · 2020-11-18T20:20:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 345ac76

Metrics [docs]

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`alert`	30	31	+1

History

💚 Build #88451 succeeded 5a3aa75
💔 Build #88432 failed dc1dc4b
💚 Build #88411 succeeded b35af3c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pmuellr

LGTM!

… edit (elastic#83578) * Adding alert.updatedAt field that only updates on user edit * Updating unit tests * Functional tests * Updating alert attributes excluded from AAD * Fixing test * PR comments

… edit (#83578) (#83720) * Adding alert.updatedAt field that only updates on user edit * Updating unit tests * Functional tests * Updating alert attributes excluded from AAD * Fixing test * PR comments

…ast user edit (#83578)" This reverts commit acc3e2f.

…ast user edit (#83578) (#83720)" This reverts commit 7f2944b.

* master: (60 commits) Forward any registry cache-control header for files (elastic#83680) Revert "[Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578)" [Security Solution][Detections] Fix adding an action to detection rules (elastic#83722) Make expectSnapshot available in all functional test runs (elastic#82932) Skip failing cypress test Increase bulk request timeout during esArchiver load (elastic#83657) [data.search] Server-side background session service (elastic#81099) [maps] convert VectorStyleEditor to TS (elastic#83582) Revert "[App Search] Engine overview layout stub (elastic#83504)" Adding documentation for global action configuration options (elastic#83557) [Metrics UI] Optimizations for Snapshot and Inventory Metadata (elastic#83596) chore(NA): update lmdb store to v0.8.15 (elastic#83726) [App Search] Engine overview layout stub (elastic#83504) [Workplace Search] Update SourceIcon to match latest changes in ent-search (elastic#83714) [Enterprise Search] Rename React Router helpers (elastic#83718) [Maps] Add 'crossed' & 'exited' events to tracking alert (elastic#82463) Updating code-owners to use new core/app-services team names (elastic#83731) Add Managed label to data streams and a view switch for the table (elastic#83049) [Maps] Add query bar inputs to geo threshold alerts tracked points & boundaries (elastic#80871) fix(NA): search examples kibana version declaration (elastic#83182) ...

… into add-logs-to-node-details * 'add-logs-to-node-details' of github.com:phillipb/kibana: (87 commits) [Maps] Add 'crossed' & 'exited' events to tracking alert (elastic#82463) Updating code-owners to use new core/app-services team names (elastic#83731) Add Managed label to data streams and a view switch for the table (elastic#83049) [Maps] Add query bar inputs to geo threshold alerts tracked points & boundaries (elastic#80871) fix(NA): search examples kibana version declaration (elastic#83182) Fixed console error, which appears when saving changes in Edit Alert flyout (elastic#83610) [Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578) Not resetting server log level if level is defined (elastic#83651) disable incremenetal build for legacy tsconfig.json (elastic#82986) [Workplace Search] Migrate SourceLogic from ent-search (elastic#83593) [Workplace Search] Port Box changes from ent-search (elastic#83675) [APM] Improve router types (elastic#83620) Bump flat to v4.1.1 (elastic#83647) Bump y18n@5 to v5.0.5 (elastic#83644) Bump jsonpointer to v4.1.0 (elastic#83641) Bump is-my-json-valid to v2.20.5 (elastic#83642) [Telemetry] Move Monitoring collection strategy to a collector (elastic#82638) Update typescript eslint to v4.8 (elastic#83520) [ML] Persist URL state for Anomaly detection jobs using metric function (elastic#83507) [ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement (elastic#83216) ...

…ode-details * 'master' of github.com:elastic/kibana: fixed pagination in connectors list (elastic#83638) Forward any registry cache-control header for files (elastic#83680) Revert "[Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578)" [Security Solution][Detections] Fix adding an action to detection rules (elastic#83722) Make expectSnapshot available in all functional test runs (elastic#82932) Skip failing cypress test Increase bulk request timeout during esArchiver load (elastic#83657) [data.search] Server-side background session service (elastic#81099) [maps] convert VectorStyleEditor to TS (elastic#83582) Revert "[App Search] Engine overview layout stub (elastic#83504)" Adding documentation for global action configuration options (elastic#83557) [Metrics UI] Optimizations for Snapshot and Inventory Metadata (elastic#83596) chore(NA): update lmdb store to v0.8.15 (elastic#83726) [App Search] Engine overview layout stub (elastic#83504) [Workplace Search] Update SourceIcon to match latest changes in ent-search (elastic#83714) [Enterprise Search] Rename React Router helpers (elastic#83718)

… edit (elastic#83578) * Adding alert.updatedAt field that only updates on user edit * Updating unit tests * Functional tests * Updating alert attributes excluded from AAD * Fixing test * PR comments

…ast user edit (elastic#83578)" This reverts commit acc3e2f.

ymao1 added 8 commits November 16, 2020 15:38

Adding alert.updatedAt field that only updates on user edit

edf89ca

Merge branch 'master' of https://github.com/elastic/kibana into alert…

c0af42a

…ing/updated-at

Updating unit tests

bdf1f67

Merging in master

33c41da

Functional tests

b35af3c

Updating alert attributes excluded from AAD

dc1dc4b

Merge branch 'master' of https://github.com/elastic/kibana into alert…

2b1b9ef

…ing/updated-at

Fixing test

5a3aa75

ymao1 self-assigned this Nov 18, 2020

ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 v8.0.0 labels Nov 18, 2020

ymao1 marked this pull request as ready for review November 18, 2020 00:22

ymao1 requested a review from a team as a code owner November 18, 2020 00:22

ymao1 requested a review from a team November 18, 2020 00:26

gmmorris self-requested a review November 18, 2020 13:38

dhurley14 approved these changes Nov 18, 2020

View reviewed changes

gmmorris approved these changes Nov 18, 2020

View reviewed changes

ymao1 added 2 commits November 18, 2020 13:34

Merge branch 'master' of https://github.com/elastic/kibana into alert…

05331d5

…ing/updated-at

PR comments

345ac76

pmuellr approved these changes Nov 18, 2020

View reviewed changes

ymao1 merged commit acc3e2f into elastic:master Nov 18, 2020

ymao1 mentioned this pull request Nov 18, 2020

[7.x] [Alerting] Add alert.updatedAt field to represent date of last user edit (#83578) #83720

Merged

ymao1 added a commit that referenced this pull request Nov 19, 2020

Revert "[Alerting] Add alert.updatedAt field to represent date of l…

6a2c415

…ast user edit (#83578)" This reverts commit acc3e2f.

ymao1 added a commit that referenced this pull request Nov 19, 2020

Revert "[Alerting] Add alert.updatedAt field to represent date of l…

8a8e24b

…ast user edit (#83578) (#83720)" This reverts commit 7f2944b.

ymao1 mentioned this pull request Nov 19, 2020

[Alerting] Add alert.updatedAt field to represent date of last user edit #83784

Merged

1 task

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 19, 2020

Revert "[Alerting] Add alert.updatedAt field to represent date of l…

fb33340

…ast user edit (elastic#83578)" This reverts commit acc3e2f.

ymao1 mentioned this pull request Nov 19, 2020

Security solutions cypress tests should be triggered on PRs related to alerts and actions #83851

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] Add `alert.updatedAt` field to represent date of last user edit#83578

[Alerting] Add `alert.updatedAt` field to represent date of last user edit#83578
ymao1 merged 10 commits intoelastic:masterfrom
ymao1:alerting/updated-at

ymao1 commented Nov 17, 2020

Uh oh!

elasticmachine commented Nov 18, 2020

Uh oh!

dhurley14 left a comment

Uh oh!

gmmorris left a comment

Uh oh!

Uh oh!

gmmorris Nov 18, 2020

Uh oh!

kibanamachine commented Nov 18, 2020

Uh oh!

pmuellr left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ymao1 commented Nov 17, 2020

Summary

Checklist

Uh oh!

elasticmachine commented Nov 18, 2020

Uh oh!

dhurley14 left a comment

Choose a reason for hiding this comment

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmmorris Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Nov 18, 2020

💚 Build Succeeded

Metrics [docs]

Saved Objects .kibana field count

History

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants