[ML] Persist URL state for Anomaly detection jobs using metric function #83507
Merged
qn895 merged 10 commits intoelastic:masterfrom Nov 18, 2020
Merged
[ML] Persist URL state for Anomaly detection jobs using metric function #83507qn895 merged 10 commits intoelastic:masterfrom
qn895 merged 10 commits intoelastic:masterfrom
Conversation
darnautov
reviewed
Nov 17, 2020
.../application/timeseriesexplorer/components/plot_function_controls/plot_function_controls.tsx
Outdated
Show resolved
Hide resolved
.../application/timeseriesexplorer/components/plot_function_controls/plot_function_controls.tsx
Outdated
Show resolved
Hide resolved
| setFunctionDescription: (func: string) => void; | ||
| selectedDetectorIndex: any; | ||
| selectedJobId: string; | ||
| selectedEntities: Record<string, any>; |
Contributor
There was a problem hiding this comment.
Could it be a more specific type?
Contributor
There was a problem hiding this comment.
@qn895 can't find it in the commit hash you've mentioned
Member
Author
There was a problem hiding this comment.
Not sure why Github is being weird but it's https://github.com/elastic/kibana/pull/83507/commits/607d7880884564514d8fb34b4972bc4ab644ea75
.../ml/public/application/timeseriesexplorer/timeseriesexplorer_utils/get_viewable_detectors.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/ml-ui (:ml) |
7 tasks
darnautov
approved these changes
Nov 18, 2020
Contributor
darnautov
left a comment
There was a problem hiding this comment.
LGTM, just some minor issues left
Comment on lines
+52
to
+55
| _selectedDetectorIndex: number, | ||
| _selectedEntities: Record<string, any>, | ||
| _selectedJobId: string, | ||
| _selectedJob: CombinedJob |
Contributor
There was a problem hiding this comment.
I believe you don't need it and can access these arguments from the component scope
Member
Author
There was a problem hiding this comment.
I think doing that will require the callback to depend on those arguments, and since they are the same as the original effect we're splitting it from, I don't see the benefits of either moving it outside of the effect or using the arguments from component scope.
x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
Show resolved
Hide resolved
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Nov 18, 2020
…on (elastic#83507) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 19, 2020
… into add-logs-to-node-details * 'add-logs-to-node-details' of github.com:phillipb/kibana: (87 commits) [Maps] Add 'crossed' & 'exited' events to tracking alert (elastic#82463) Updating code-owners to use new core/app-services team names (elastic#83731) Add Managed label to data streams and a view switch for the table (elastic#83049) [Maps] Add query bar inputs to geo threshold alerts tracked points & boundaries (elastic#80871) fix(NA): search examples kibana version declaration (elastic#83182) Fixed console error, which appears when saving changes in Edit Alert flyout (elastic#83610) [Alerting] Add `alert.updatedAt` field to represent date of last user edit (elastic#83578) Not resetting server log level if level is defined (elastic#83651) disable incremenetal build for legacy tsconfig.json (elastic#82986) [Workplace Search] Migrate SourceLogic from ent-search (elastic#83593) [Workplace Search] Port Box changes from ent-search (elastic#83675) [APM] Improve router types (elastic#83620) Bump flat to v4.1.1 (elastic#83647) Bump y18n@5 to v5.0.5 (elastic#83644) Bump jsonpointer to v4.1.0 (elastic#83641) Bump is-my-json-valid to v2.20.5 (elastic#83642) [Telemetry] Move Monitoring collection strategy to a collector (elastic#82638) Update typescript eslint to v4.8 (elastic#83520) [ML] Persist URL state for Anomaly detection jobs using metric function (elastic#83507) [ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement (elastic#83216) ...
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 19, 2020
…on (elastic#83507) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow up of #81662. It brings several improvements such as:
metric(for when user bookmarks or refreshes the page)Behavior
By default, when first viewing the job in the Single Metric Viewer, it will pick the function description associated with the highest anomaly scoring record. In this example, the view defaults to
min.Upon changing the plotting function and refresh of the page, the view will be persisted to the previously selected function.
Checklist
Delete any items that are not applicable to this PR.