Skip to content

[Uptime] Mock implementation to account for math flakiness test#83535

Merged
shahzad31 merged 2 commits intoelastic:masterfrom
shahzad31:fix-ping-hist-interval-flaky-tets
Nov 17, 2020
Merged

[Uptime] Mock implementation to account for math flakiness test#83535
shahzad31 merged 2 commits intoelastic:masterfrom
shahzad31:fix-ping-hist-interval-flaky-tets

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented Nov 17, 2020

Summary

Resolves: #82233
Resolves: #81460

Interval value was being tested as being snapshot, that has it's won tests so mocking here to resolve flakiness

@shahzad31 shahzad31 marked this pull request as ready for review November 17, 2020 11:50
@shahzad31 shahzad31 requested a review from a team as a code owner November 17, 2020 11:50
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 17, 2020
Copy link
Copy Markdown
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 17, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 2fb04a6 into elastic:master Nov 17, 2020
@shahzad31 shahzad31 deleted the fix-ping-hist-interval-flaky-tets branch November 17, 2020 13:44
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Nov 17, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 17, 2020
* master: (51 commits)
  [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439)
  adds xpack.security.authc.selector.enabled setting (elastic#83551)
  skip flaky suite (elastic#77279)
  [ML] Improve support for script and aggregation fields in anomaly detection jobs (elastic#81923)
  [Workplace Search] Migrate SourcesLogic from ent-search (elastic#83544)
  [ML] Add UI test for feature importance features (elastic#82677)
  [Maps] Improve icons for all layer types (elastic#83503)
  Replace experimental badge with Beta (elastic#83468)
  [Fleet][EPM] Unified install and archive (elastic#83384)
  Move src/legacy/server/keystore to src/cli (elastic#83483)
  Used SO for saving the API key IDs that should be deleted (elastic#82211)
  [Uptime] Mock implementation to account for math flakiness test (elastic#83535)
  [Workplace Search] Enable check for org context based on URL (elastic#83487)
  [App Search] Added all Document related routes and logic (elastic#83324)
  [Alerting UI] Fix console error when setting connector params (elastic#83333)
  [Discover] Allow custom name for fields via index pattern field management (elastic#70039)
  [Uptime] Fix monitor list down histogram (elastic#83411)
  remove headers timeout hack, rely on nodejs timeouts (elastic#83419)
  [ML] Update console autocomplete for ML data frame evaluate API (elastic#83151)
  [Lens] Color in dimension trigger (elastic#76871)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0

Projects

None yet

4 participants