[Fleet][EPM] Unified install and archive#83384
Merged
jfsiii merged 13 commits intoelastic:masterfrom Nov 17, 2020
jfsiii:unified-install-and-archive
Merged
[Fleet][EPM] Unified install and archive#83384jfsiii merged 13 commits intoelastic:masterfrom jfsiii:unified-install-and-archive
jfsiii merged 13 commits intoelastic:masterfrom
jfsiii:unified-install-and-archive
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
neptunian
approved these changes
Nov 17, 2020
Contributor
|
Looks good! |
neptunian
reviewed
Nov 17, 2020
| const sharedKey = ({ name, version, installSource }: SharedKey) => | ||
| `${name}-${version}-${installSource}`; | ||
|
|
||
| export const getPackageInfo = (args: SharedKey) => { |
Contributor
There was a problem hiding this comment.
I wonder if we should name this something different as we already have a getPackageInfo https://github.com/elastic/kibana/pull/83384/files#diff-baf8294e3f474e4f2436b376ab8b1c1c8a611c0d0455ff88e78563c613deeb4dL106
Contributor
Author
There was a problem hiding this comment.
I think it's ok for the names to be the same since they're in different services. I also think one might replace/wrap the other eventually. I'll leave as-is and we can rename later if we want.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 17, 2020
* master: (51 commits) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) skip flaky suite (elastic#77279) [ML] Improve support for script and aggregation fields in anomaly detection jobs (elastic#81923) [Workplace Search] Migrate SourcesLogic from ent-search (elastic#83544) [ML] Add UI test for feature importance features (elastic#82677) [Maps] Improve icons for all layer types (elastic#83503) Replace experimental badge with Beta (elastic#83468) [Fleet][EPM] Unified install and archive (elastic#83384) Move src/legacy/server/keystore to src/cli (elastic#83483) Used SO for saving the API key IDs that should be deleted (elastic#82211) [Uptime] Mock implementation to account for math flakiness test (elastic#83535) [Workplace Search] Enable check for org context based on URL (elastic#83487) [App Search] Added all Document related routes and logic (elastic#83324) [Alerting UI] Fix console error when setting connector params (elastic#83333) [Discover] Allow custom name for fields via index pattern field management (elastic#70039) [Uptime] Fix monitor list down histogram (elastic#83411) remove headers timeout hack, rely on nodejs timeouts (elastic#83419) [ML] Update console autocomplete for ML data frame evaluate API (elastic#83151) [Lens] Color in dimension trigger (elastic#76871) ...
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
jfsiii
pushed a commit
that referenced
this pull request
Nov 20, 2020
## Summary * Further reduce differences between installing uploaded vs registry package * Improve cache/store names, TS types, etc. Including key by name + version + source * Add a cache/store for PackageInfo (e.g. results metadata from registry's /package/version/ response) * Remove ensureCachedArchiveInfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary