Migrate /translations route to core#83280
Merged
pgayvallet merged 3 commits intoelastic:masterfrom Nov 16, 2020
Merged
Conversation
pgayvallet
commented
Nov 12, 2020
Comment on lines
+149
to
+150
| // setup i18n prior to any other service, to have translations ready | ||
| const i18nServiceSetup = await this.i18n.setup({ http: httpSetup, pluginPaths }); |
Contributor
Author
There was a problem hiding this comment.
Had to move this after the http service setup to register the route. I could move i18n initialization in another method (like we did for plugin.discover) to keep the i18n setup before context and http, but I don't think this is really necessary
Comment on lines
+22
to
+26
| export default function ({ getService }: FtrProviderContext) { | ||
| const supertest = getService('supertest'); | ||
|
|
||
| describe('compression', () => { | ||
| it(`uses compression when there isn't a referer`, async () => { |
Contributor
Author
There was a problem hiding this comment.
Extracted / converted to TS from test/api_integration/apis/core/index.js
Comment on lines
+60
to
+65
| headers: { | ||
| 'content-type': 'application/json', | ||
| 'cache-control': 'must-revalidate', | ||
| etag: translationCache.hash, | ||
| }, | ||
| body: translationCache.translations, |
Contributor
Author
There was a problem hiding this comment.
As discussed with @restrry, we ideally should use cache-control instead of etag here in dist mode to avoid an unnecessary roundtrip. However as this requires some refactoring to be able to add a path prefix,suffix or query param to invalidate the request when the kibana version is bumped (as we do with static assets), it will be done at a later time. I will create an issue for that before the current PR got merged.
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
mshustov
approved these changes
Nov 16, 2020
Contributor
mshustov
left a comment
There was a problem hiding this comment.
tested locally, looks good
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Nov 16, 2020
* move i18n route to core * add FTR test for endpoint
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 16, 2020
* master: Migrate `/translations` route to core (elastic#83280) [APM] Ensure APM jest script can run (elastic#83398) [Uptime] Monitor status alert use url as instance (elastic#81736) [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259) TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964) [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139) Skips Vega test skip flaky suite (elastic#79967) [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020) Added ability to fire actions when an alert instance is resolved (elastic#82799) [ML] Adds functional tests for the index data visualizer card contents (elastic#83174)
pgayvallet
added a commit
that referenced
this pull request
Nov 16, 2020
* move i18n route to core * add FTR test for endpoint
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 16, 2020
… into add-logs-to-node-details * 'add-logs-to-node-details' of github.com:phillipb/kibana: fix tall vislib charts in visualize (elastic#83340) [Lens] Avoid unnecessary data fetching on dimension flyout open (elastic#82957) [Security Solution][Case] Change case connector minimum required license to basic (elastic#83401) fix logstash central pipeline management test (elastic#83281) [Search] Send to background UI (elastic#81793) Migrate `/translations` route to core (elastic#83280) [APM] Ensure APM jest script can run (elastic#83398) [Uptime] Monitor status alert use url as instance (elastic#81736) [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259) TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964) [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139) Skips Vega test skip flaky suite (elastic#79967) [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020) Added ability to fire actions when an alert instance is resolved (elastic#82799)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up of #81799
Migrate the
/translations/{locale}.jsonroute to core.Checklist