[Uptime] Monitor status alert use url as instance#81736
Merged
shahzad31 merged 16 commits intoelastic:masterfrom Nov 16, 2020
Merged
[Uptime] Monitor status alert use url as instance#81736shahzad31 merged 16 commits intoelastic:masterfrom
shahzad31 merged 16 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
gmmorris
reviewed
Oct 27, 2020
...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
mdefazio
approved these changes
Nov 2, 2020
Contributor
mdefazio
left a comment
There was a problem hiding this comment.
As far as how the table is used, I think this is good. I agree that the truncation / flexibility should occur on the instance/url field, even though there are times that the unique part will be cut off.
Contributor
Author
|
@elasticmachine merge upstream |
andrewvc
requested changes
Nov 5, 2020
Contributor
andrewvc
left a comment
There was a problem hiding this comment.
Mostly looks good, but after thinking about it more monitor.name makes the most sense to prioritize in the display
…/kibana into use-url-as-instance-id
gmmorris
reviewed
Nov 6, 2020
...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx
Show resolved
Hide resolved
gmmorris
approved these changes
Nov 6, 2020
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
LGTM, seems to be behaving as expected :)
My only concern is about hard coded px values and I've pinged Design to get their thoughts, but if they're good with it then ✅
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 16, 2020
* master: Migrate `/translations` route to core (elastic#83280) [APM] Ensure APM jest script can run (elastic#83398) [Uptime] Monitor status alert use url as instance (elastic#81736) [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259) TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964) [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139) Skips Vega test skip flaky suite (elastic#79967) [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020) Added ability to fire actions when an alert instance is resolved (elastic#82799) [ML] Adds functional tests for the index data visualizer card contents (elastic#83174)
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Nov 16, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 16, 2020
… into add-logs-to-node-details * 'add-logs-to-node-details' of github.com:phillipb/kibana: fix tall vislib charts in visualize (elastic#83340) [Lens] Avoid unnecessary data fetching on dimension flyout open (elastic#82957) [Security Solution][Case] Change case connector minimum required license to basic (elastic#83401) fix logstash central pipeline management test (elastic#83281) [Search] Send to background UI (elastic#81793) Migrate `/translations` route to core (elastic#83280) [APM] Ensure APM jest script can run (elastic#83398) [Uptime] Monitor status alert use url as instance (elastic#81736) [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259) TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964) [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139) Skips Vega test skip flaky suite (elastic#79967) [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020) Added ability to fire actions when an alert instance is resolved (elastic#82799)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #80932
For uptime monitor status alert, using url as instance id, so that user can have better understanding which alert instance they need to mute.
Also update table layout in alerting UI to make it more user friendly.
After:
Before:
