[TSVB] offset option doesn't work properly for some values#83051
Merged
alexwizp merged 4 commits intoelastic:masterfrom Nov 26, 2020
Merged
[TSVB] offset option doesn't work properly for some values#83051alexwizp merged 4 commits intoelastic:masterfrom
alexwizp merged 4 commits intoelastic:masterfrom
Conversation
Closes: elastic#40299
Contributor
Author
|
@kobelb could you please have a look that? I need your eyes to be sure that it will be finally fixed. |
Contributor
Author
|
@elasticmachine merge upstream |
stratoula
approved these changes
Nov 16, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
LGTM, I am not sure if the previous bug still exists though. I tried to do some tests but couldn't reproduce it, and as this solves the problem with the offsets I approve it.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Nov 26, 2020
Closes: elastic#40299 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
that referenced
this pull request
Nov 26, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 30, 2020
* master: [Security Solution] Exceptions Cypress tests (elastic#81759) [ML] Fix spaces job ID check (elastic#84404) [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062) skip flaky suite (elastic#84440) skip flaky suite (elastic#84445) [APM] Fix missing `service.node.name` (elastic#84269) Upgrade fp-ts to 2.8.6 (elastic#83866) Added data streams privileges to better control delete actions in UI (elastic#83573) Improve short-url redirect validation (elastic#84366) TSVB offsets (elastic#83051) [Discover] Fix navigating back when changing index pattern (elastic#84061) [Logs UI] Polish the UI for the log entry examples in the anomaly table (elastic#82139) [Logs UI] Limit the height of the "view in context" container (elastic#83178) [Application Usage] Update `schema` with new `fleet` rename (elastic#84327) fix identation in list (elastic#84301)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #40299
Summary
This PR is reverting #34283 because this PR brought us new issues with offset. Also I think date should be also parsed in UTC on server side to avoid this types of issues.
In my local offset works fine (second chart with 1y offset)
Checklist
Delete any items that are not applicable to this PR.
For maintainers