Timeseries Visual Builder - DST shift in historic data#34283
Merged
alexwizp merged 2 commits intoelastic:masterfrom Apr 9, 2019
Merged
Timeseries Visual Builder - DST shift in historic data#34283alexwizp merged 2 commits intoelastic:masterfrom
alexwizp merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
alexwizp
commented
Apr 2, 2019
src/legacy/core_plugins/metrics/server/lib/vis_data/response_processors/series/time_shift.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 9, 2019
* Timeseries Visual Builder - DST shift in historic data * Timeseries Visual Builder - DST shift in historic data - performance optimization
alexwizp
added a commit
that referenced
this pull request
Apr 9, 2019
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #33006
Summary
In the timeseries visualization of visual builder we compare different series from this week, last week (1w) and 2 weeks (2w) ago, i.e. using "offset series time" in the options of the metric
After the daylight saving time shift in the US suddenly our historic data (offsetted timeseries) got also shifted and is displayed with 1 hour offset. The current data after the shift is displaying fine.
Reason is probably the series when selected for the last 7 days uses the same timestamps on the X-Axis for this week as for last week and old data gets converted to the new "time zone".
Note: Timestamps are UTC everywhere (code, server, ES?), data is from Europe, so now DST shift involved here.
Steps to reproduce:
Create multiple timeseries in visual builder which spans over the DST shift
Observe how peaks in historic data shift by 1 hour
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers