Change monaco theme background color to match other form inputs#82451
Merged
ryankeairns merged 1 commit intoelastic:masterfrom Nov 4, 2020
Merged
Change monaco theme background color to match other form inputs#82451ryankeairns merged 1 commit intoelastic:masterfrom
ryankeairns merged 1 commit intoelastic:masterfrom
Conversation
Contributor
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
poffdeluxe
approved these changes
Nov 3, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
Nice! Good catch. Some of these colors were chosen a long long long time ago so definitely a good update
myasonik
approved these changes
Nov 4, 2020
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Nov 4, 2020
ryankeairns
added a commit
that referenced
this pull request
Nov 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #82116 #82272
Summary
It was noticed in the runtime fields work that a style override was being used for the monaco background. After further thought, it struck me that the default/theme background color ought to be changed.
Currently, it's set to an empty shade (i.e. white in light mode), however this component is used primarily as an input mechanism. Similar to the EUI code editor/blocks, I've changed the default theme to use the
$euiFormBackgroundColorcolor.As far as I can tell, this shared Kibana component is used in Vega, Canvas, and Painless Lab. I made some minor adjustments to Canvas and Painless, as a result, but all three have been checked in both light and dark mode.
Sample screenshots from light mode
Canvas
Changed tray bg; also checked this in 'maximized' mode
Painless Lab
Changed background of left pane to match
Viz/Vega
Monaco is used on the debug/spec tab only