Use monacco editor in the inspector request panel#82272
Merged
alexwizp merged 10 commits intoelastic:masterfrom Nov 6, 2020
Merged
Use monacco editor in the inspector request panel#82272alexwizp merged 10 commits intoelastic:masterfrom
alexwizp merged 10 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
nreese
approved these changes
Nov 3, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Thanks for changing out the editor. This is much faster with large responses.
Maps changes LGTM
code review, tested in chrome
ryankeairns
reviewed
Nov 3, 2020
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
@alexwizp I'll have a design PR for you that tidies up the styles a bit.
Contributor
Author
|
@elasticmachine merge upstream |
stratoula
approved these changes
Nov 4, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
LGTM! I tested it locally on Chrome, it works much better for larger json. Moreover, we make the inspector bundle smaller which is always great!! 👏
ryankeairns
approved these changes
Nov 4, 2020
| // TODO: EUI to allow for custom classNames to inner elements | ||
| // Or supply this as default | ||
| > div { | ||
| .euiFlyoutBody__overflowContent { |
Contributor
There was a problem hiding this comment.
I'm going to create a separate PR - after you merge this one - to clean this up a bit. I've got some changes in the works, but they're going to take more time to iron out across the various implementations (i.e. I was close but realized it broke the dashboard layout ;) ).
Contributor
Author
|
ping @elastic/kibana-app-arch |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@lukeelmers @ppisljar we need someone from AppArch to review that, please. |
Contributor
💛 Build succeeded, but was flaky
Test FailuresX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/disable·ts.alerting api integration security and spaces enabled Alerts disable space_1_all at space1 should still be able to disable alert when AAD is brokenStandard OutStack TraceMetrics [docs]@kbn/optimizer bundle module count
async chunk count
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
lukeelmers
approved these changes
Nov 6, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM! Tested Chrome (macOS) and seems to be working well 👍
Comment on lines
+238
to
+254
| kibana={ | ||
| Object { | ||
| "notifications": Object { | ||
| "toasts": Object { | ||
| "danger": [Function], | ||
| "show": [Function], | ||
| "success": [Function], | ||
| "warning": [Function], | ||
| }, | ||
| }, | ||
| "overlays": Object { | ||
| "openFlyout": [Function], | ||
| "openModal": [Function], | ||
| }, | ||
| "services": Object {}, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit: It would be preferable if there were any way to update the unit tests so that these dependencies didn't appear in snapshots... otherwise they break any time future changes are made to the services, even if they're non-breaking
Contributor
Author
There was a problem hiding this comment.
I'll think how to refactor that test, and create a separate PR for that. I see here we just test a snapshot. It's not so useful...
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Nov 6, 2020
* Use monacco editor in the inspector request panel Closes: elastic#81921 * insRequestCodeViewer -> insRequestCodeViewer * remove uiSettings from props * fix functional tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Nov 6, 2020
* Use monacco editor in the inspector request panel Closes: #81921 * insRequestCodeViewer -> insRequestCodeViewer * remove uiSettings from props * fix functional tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #81921
Summary
We should use Monaco as a read-only editor instead of EuiCodeBlock to present the request and response in the inspector requests panel, since EuiCodeBlock has very poor performance for larger responses and can easily freeze your page for some time (also it has no collapsing, which might be useful there).
Screens
Checklist
Delete any items that are not applicable to this PR.
For maintainers