[Telemetry] [Schema] remove number type and support all es number types#81774
Merged
Bamieh merged 6 commits intoelastic:masterfrom Oct 30, 2020
Merged
Conversation
…ema_remove_number_type
lukeelmers
approved these changes
Oct 27, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
app arch code change LGTM
jportner
approved these changes
Oct 27, 2020
Comment on lines
61
to
+62
| authProviderCount: { | ||
| type: 'number', | ||
| type: 'long', |
Contributor
There was a problem hiding this comment.
Realistically, we wouldn't ever have enough auth providers in Kibana to warrant a "long". But we don't enforce an actual limit, so it's probably the most appropriate type to use.
TinaHeiligers
requested changes
Oct 27, 2020
Contributor
TinaHeiligers
left a comment
There was a problem hiding this comment.
We should be using floats for all averages.
packages/kbn-telemetry-tools/src/tools/__fixture__/mock_schema.json
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Oct 30, 2020
Bamieh
added a commit
that referenced
this pull request
Oct 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 30, 2020
* master: (71 commits) [Chrome] Extension to append an element to the last breadcrumb (elastic#82015) [Monitoring] Thread pool rejections alert (elastic#79433) [Actions] Fix actionType type on registerType function (elastic#82125) [Security Solution] Modal for saving timeline (elastic#81802) add tests for index pattern switching (elastic#81987) TS project references for share plugin (elastic#82051) [Graph] Fix problem with duplicate ids (elastic#82109) skip 'returns a single bucket if array has 1'. related elastic#81460 Add a link to documentation in the alerts and actions management UI (elastic#81909) [Fleet] fix duplicate ingest pipeline refs (elastic#82078) Context menu trigger for URL Drilldown (elastic#81158) SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621) Fixed dead links (elastic#78696) [Search] Add "restore" to session service (elastic#81924) fix Lens heading structure (elastic#81752) [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011) Remove legacy app arch items from codeowners. (elastic#82084) [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939) Expressions/migrations2 (elastic#81281) [Telemetry] [Schema] remove number type and support all es number types (elastic#81774) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove "number" type from the collector schema in favor of more accurate number types. Schema now supports the following number types:
Replaced all existing
numbertypes (3 total) withlong.Closes #81597