Context menu trigger for URL Drilldown#81158
Merged
streamich merged 13 commits intoelastic:masterfrom Oct 30, 2020
streamich:context-menu-2
Merged
Context menu trigger for URL Drilldown#81158streamich merged 13 commits intoelastic:masterfrom streamich:context-menu-2
streamich merged 13 commits intoelastic:masterfrom
streamich:context-menu-2
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
approved these changes
Oct 29, 2020
Contributor
There was a problem hiding this comment.
Looks good. Tested.
I think we should also update user-facing docs: https://www.elastic.co/guide/en/kibana/master/url-drilldown.html#trigger-picker
| defaultMessage: 'Context menu', | ||
| }), | ||
| description: i18n.translate('embeddableApi.contextMenuTrigger.description', { | ||
| defaultMessage: 'A panel top-right corner context menu click.', |
Contributor
There was a problem hiding this comment.
I'd say something like: "Adds a new option to panel's context menu"
Contributor
There was a problem hiding this comment.
Also noticed "Show option on... context menu" doesn't make much sense :(
not sure what to do about it
ThomThomson
approved these changes
Oct 29, 2020
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Tested locally on chrome and everything LGTM.
Really impressed with how the available variables are populated when you move from a context menu trigger to a value click trigger and back.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
page load bundle size
History
To update your PR or re-run it, just comment with: |
streamich
added a commit
that referenced
this pull request
Oct 30, 2020
* feat: 🎸 add context menu trigger to URL drilldown * fix: 🐛 translate "Drilldowns" grouping title * feat: 🎸 add dynamic action grouping to dynamic actions * fix: 🐛 add translations to trigger texts * feat: 🎸 enambe ctx menu trigger in both flyouts, move to end * fix: 🐛 show context menu event scope variable sfor ctx menu * test: 💍 add tests * fix: 🐛 use correct namespace for translation keys * docs: ✏️ update autogenerated docs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 30, 2020
* master: (71 commits) [Chrome] Extension to append an element to the last breadcrumb (elastic#82015) [Monitoring] Thread pool rejections alert (elastic#79433) [Actions] Fix actionType type on registerType function (elastic#82125) [Security Solution] Modal for saving timeline (elastic#81802) add tests for index pattern switching (elastic#81987) TS project references for share plugin (elastic#82051) [Graph] Fix problem with duplicate ids (elastic#82109) skip 'returns a single bucket if array has 1'. related elastic#81460 Add a link to documentation in the alerts and actions management UI (elastic#81909) [Fleet] fix duplicate ingest pipeline refs (elastic#82078) Context menu trigger for URL Drilldown (elastic#81158) SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621) Fixed dead links (elastic#78696) [Search] Add "restore" to session service (elastic#81924) fix Lens heading structure (elastic#81752) [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011) Remove legacy app arch items from codeowners. (elastic#82084) [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939) Expressions/migrations2 (elastic#81281) [Telemetry] [Schema] remove number type and support all es number types (elastic#81774) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #70457
Checklist
Delete any items that are not applicable to this PR.
For maintainers