Ability to select legend position for tile map visualizations by ppisljar · Pull Request #8176 · elastic/kibana

ppisljar · 2016-09-07T09:08:25Z

allows choosing between topleft/topright/bottomleft/bottomright for legend position on tile_map
adds title to the tile_map legend

closes #4945 - legendPosition for tile map visualization

epixa · 2016-09-12T20:12:47Z

This needs to be rebased

ppisljar · 2016-09-13T05:49:08Z

does it make sense to only rebase when someone has time to review ?

epixa · 2016-09-13T12:12:34Z

@ppisljar It's your call. Personally, I subscribe to the "rebase early and often" philosophy. If there's a conflict with something, I want to deal with it as soon as possible so that multiple conflicts do not compound to make the situation dire.

Bargs

Let's add a space between these words.

I'm noticing some odd bouncing behavior of the legend in the topleft position. I think the legend probably needs to float to the right of the map controls, what do you think?

Shouldn't the legend title reflect the custom label?

ppisljar · 2016-11-08T10:57:21Z

@Bargs regarding custom label, i dont think so ... metric custom label should be (and is) applied in the legend.
issue with top left legend is fixed. please take another look.

Bargs · 2016-11-08T16:29:49Z

Yeah you're right about the label, I don't know what I was thinking

thomasneirynck

agreed with @Bargs that we should put spaces between topleft, topright, etc...

Position on top left is nice, next to the zoom and toolbar buttons.

For the rest, LGTM. Useful change!

Bargs · 2016-11-10T23:44:01Z

Great change! LGTM

Backports PR #8176 **Commit 1:** updating legendPosition to read values from config * Original sha: 6aa3476 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T08:31:14Z **Commit 2:** adding legendPosition setting to tile map * Original sha: f10fb0e * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T08:31:45Z **Commit 3:** legendPosition for tile map * Original sha: 83a5135 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T08:32:06Z **Commit 4:** adding title to tile map legend * Original sha: 9e08139 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T09:05:50Z **Commit 5:** fixing top left position * Original sha: 76f66a8 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-08T10:56:56Z **Commit 6:** adding text/value to legendPosition options * Original sha: c8ede10 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-09T11:52:46Z

…c#9043) Backports PR elastic#8176 **Commit 1:** updating legendPosition to read values from config * Original sha: 6aa3476 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T08:31:14Z **Commit 2:** adding legendPosition setting to tile map * Original sha: f10fb0e * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T08:31:45Z **Commit 3:** legendPosition for tile map * Original sha: 83a5135 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T08:32:06Z **Commit 4:** adding title to tile map legend * Original sha: 9e08139 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T09:05:50Z **Commit 5:** fixing top left position * Original sha: 76f66a8 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-08T10:56:56Z **Commit 6:** adding text/value to legendPosition options * Original sha: c8ede10 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-09T11:52:46Z Former-commit-id: 19723a6

>[!IMPORTANT] This PR introduces the Borealis enabled EUI package to `8.x`. The intention is to support new features being developed that need to live in `main` as well as `8.x`. >[!IMPORTANT] All `8.x` versions should continue to use the current Amsterdam theme. To ensure this even with upcoming changes to the default theme for EUI, we're adding `euiThemeAmsterdam` on `EuiProvider` usages manually. ## Description This PR introduces all previous Borealis related PR changes but excludes the specific changes to support `@elastic/eui-theme-borealis` as only Amsterdam is supported as theme in `8.x`. Previous PRs - #199993 - #201049 - #202073 --- `v97.3.1`⏩`v98.2.1-borealis.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- # `@elastic/eui` ## [`v98.2.1`](https://github.com/elastic/eui/releases/v98.2.1) - Updated the EUI theme color values to use a full 6 char hex code format ([#8244](elastic/eui#8244)) ## [`v98.2.0`](https://github.com/elastic/eui/releases/v98.2.0) - Added two new icons: `contrast` and `contrastHigh` ([#8216](elastic/eui#8216)) - Updated `EuiDataGrid` content to have a transparent background. ([#8220](elastic/eui#8220)) **Accessibility** - When the tooltips components (`EuiTooltip`, `EuiIconTip`) are used inside components that handle the Escape key (like `EuiFlyout` or `EuiModal`), pressing the Escape key will now only close the tooltip and not the entire wrapping component. ([#8140](elastic/eui#8140)) - Improved the accessibility of `EuiCodeBlock`s by ([#8195](elastic/eui#8195)) - adding screen reader only labels - adding `role="dialog"` on in fullscreen mode - ensuring focus is returned on closing fullscreen mode # Borealis updates - [Visual Refresh] Update color token mappings ([#8211](elastic/eui#8211)) - [Visual Refresh] Introduce shared popover arrow styles to Borealis ([#8212](elastic/eui#8212)) - [Visual Refresh] Add forms.maxWidth token ([#8221](elastic/eui#8221)) - [Visual Refresh] Set darker shade for subdued text ([#8224](elastic/eui#8224)) - [Visual Refresh] Remove support for accentSecondary badges ([#8224](elastic/eui#8227)) - [Visual Refresh] Add severity vis colors ([#8247](elastic/eui#8247)) --- # `@elastic/eui` ## [`v98.1.0`](https://github.com/elastic/eui/releases/v98.1.0) - Updated `EuiBetaBadge` with a new `warning` color variant ([#8177](elastic/eui#8177)) **Accessibility** - Ensures `autoFocus` on `EuiSelectableList` triggers initial focus ([#8091](elastic/eui#8091)) - Improved the accessibility of `EuiSearchBarFilters` by: ([#8091](elastic/eui#8091)) - adding a more descriptive `aria-label` to selection filter buttons - ensuring the selection listbox is initially focused when opening a selection popover - Improved the accessibility experience of tabs (EuiTab, EuiTabs): tab group is a tab stop and tabs can be traversed with arrow keys. ([#8116](elastic/eui#8116)) - Updated `EuiCodeBlock` with a new `copyAriaLabel` prop, which allows setting a custom screen reader label on the copy button. ([#8176](elastic/eui#8176)) **CSS-in-JS conversions** - Removed the following global Sass variables: ([#8169](elastic/eui#8169)) - `$euiButtonMinWidth` - `$euiDatePickerCalendarWidth` - Removed the following Sass animations: ([#8169](elastic/eui#8169)) - `euiAnimFadeIn` - `euiGrow` - `focusRingAnimate` - `focusRingAnimateLarge` - `euiButtonActive` - Removed the following Sass mixins: ([#8169](elastic/eui#8169)) - `euiFullHeight` - `euiSlightShadowHover` - `datePickerArrow` # Borealis updates - [Visual Refresh] Fix euiColorFullShade Sass variable mapping (elastic/eui#8178) --- # `@elastic/eui` ## [`v98.0.0`](https://github.com/elastic/eui/releases/v98.0.0) **Bug fixes** - Fixed an `EuiDataGrid` bug where column actions where not clickable when `EuiDataGrid` with `columnVisibility.canDragAndDropColumns` was used inside a modal ([#8135](elastic/eui#8135)) **Breaking changes** - Removed `EuiFormRow`'s deprecated `columnCompressedSwitch` display prop. Use `columnCompressed` instead ([#8113](elastic/eui#8113)) # Borealis updates **Bug fixes** - Fixed computed border token mapping (elastic/eui#8170)

ppisljar added review Feature:Vislib Vislib chart implementation labels Sep 7, 2016

ppisljar assigned Bargs Sep 7, 2016

ppisljar force-pushed the fix/4945 branch from 16a0278 to f67bb01 Compare September 8, 2016 07:14

epixa changed the title ~~Fix/4945 - legendPosition for tile map visualization~~ Ability to select legend position for tile map visualizations Sep 9, 2016

Bargs added needs updates and removed review labels Sep 13, 2016

ppisljar force-pushed the fix/4945 branch from f67bb01 to 3dbfb80 Compare September 23, 2016 06:16

ppisljar added review and removed needs updates labels Sep 23, 2016

ppisljar added the v5.1.0 label Oct 3, 2016

ppisljar force-pushed the fix/4945 branch from 3dbfb80 to 3c38377 Compare October 7, 2016 14:03

Bargs suggested changes Oct 7, 2016

View reviewed changes

Bargs added needs updates and removed review labels Oct 7, 2016

Bargs added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Oct 31, 2016

thomasneirynck self-assigned this Nov 8, 2016

Bargs added review and removed needs updates labels Nov 8, 2016

thomasneirynck approved these changes Nov 8, 2016

View reviewed changes

ppisljar added 5 commits November 9, 2016 12:41

updating legendPosition to read values from config

6aa3476

adding legendPosition setting to tile map

f10fb0e

legendPosition for tile map

83a5135

adding title to tile map legend

9e08139

fixing top left position

76f66a8

adding text/value to legendPosition options

c8ede10

ppisljar force-pushed the fix/4945 branch from 727f2a9 to c8ede10 Compare November 9, 2016 11:53

Bargs approved these changes Nov 10, 2016

View reviewed changes

Bargs removed their assignment Nov 10, 2016

ppisljar merged commit 86cff96 into elastic:master Nov 11, 2016

elastic-jasper mentioned this pull request Nov 11, 2016

[5.x] Ability to select legend position for tile map visualizations #9043

Merged

ppisljar deleted the fix/4945 branch November 11, 2016 08:48

ppisljar added the backported label Dec 2, 2016

epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016

ppisljar restored the fix/4945 branch September 26, 2018 10:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to select legend position for tile map visualizations#8176

Ability to select legend position for tile map visualizations#8176
ppisljar merged 6 commits intoelastic:masterfrom
ppisljar:fix/4945

ppisljar commented Sep 7, 2016 •

edited by epixa

Loading

Uh oh!

epixa commented Sep 12, 2016

Uh oh!

ppisljar commented Sep 13, 2016

Uh oh!

epixa commented Sep 13, 2016

Uh oh!

Bargs left a comment

Uh oh!

ppisljar commented Nov 8, 2016

Uh oh!

Bargs commented Nov 8, 2016

Uh oh!

thomasneirynck left a comment

Uh oh!

Bargs commented Nov 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ppisljar commented Sep 7, 2016 • edited by epixa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

epixa commented Sep 12, 2016

Uh oh!

ppisljar commented Sep 13, 2016

Uh oh!

epixa commented Sep 13, 2016

Uh oh!

Bargs left a comment

Choose a reason for hiding this comment

Uh oh!

ppisljar commented Nov 8, 2016

Uh oh!

Bargs commented Nov 8, 2016

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Bargs commented Nov 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ppisljar commented Sep 7, 2016 •

edited by epixa

Loading