[Ingest Manager] send path as separate property in Full Agent Policy#80540
Merged
neptunian merged 1 commit intoelastic:masterfrom Oct 14, 2020
Merged
[Ingest Manager] send path as separate property in Full Agent Policy#80540neptunian merged 1 commit intoelastic:masterfrom
neptunian merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
approved these changes
Oct 14, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
I was surprised to see the path end with a slash but it's clearly intentional and we have tests 🚀
3 tasks
Contributor
|
Same as @jfsiii - are we sure the trailing slash is needed? IIRC agent will start calls with |
Contributor
Author
|
@jen-huang It's something I confirmed with @blakerouse. Since it is written in the |
blakerouse
approved these changes
Oct 14, 2020
blakerouse
left a comment
There was a problem hiding this comment.
Sending with ending slash seems correct because when you enroll with a path the code also places the / at the end.
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Oct 14, 2020
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Oct 14, 2020
neptunian
added a commit
that referenced
this pull request
Oct 14, 2020
neptunian
added a commit
that referenced
this pull request
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the Fleet Kibana config in the FullAgentPolicy, path should not be sent as part of host property, taken from the user's Settings for kibana urls. Path, if it exists, will be sent as
pathotherwise no property will be sent as part of the config. Path will no longer be part ofhosts.Related:
elastic/beats#21804
elastic/beats#21601