[ML] Datagrid: Ensure column content with 'boolean' schema is not capitalized#80041
Merged
alvarezmelissa87 merged 2 commits intoelastic:masterfrom Oct 13, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
andreadelrio
requested changes
Oct 8, 2020
Contributor
andreadelrio
left a comment
There was a problem hiding this comment.
Sent a Sass suggestion. Also we'll look into implementing this change on the EUI side so you'd eventually wouldn't need this override.
Comment on lines
1
to
6
Contributor
There was a problem hiding this comment.
Suggested change
| div.mlDataGrid .euiDataGridRowCell--boolean { | |
| text-transform: none; | |
| } | |
| .mlDataGrid { | |
| .euiDataGridRowCell--boolean { | |
| text-transform: none; | |
| } | |
| } | |
We usually use nesting whenever possible in Sass.
Contributor
Author
There was a problem hiding this comment.
Good suggestion - updated in ca000bc97d7dd455963543c7918c5d32e04d9ae2
andreadelrio
approved these changes
Oct 8, 2020
qn895
approved these changes
Oct 12, 2020
Member
|
LGTM |
ca000bc to
be1aab8
Compare
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Oct 13, 2020
…italized (elastic#80041) * overwrite css capitalization of boolean schema columns * update css
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 13, 2020
…a-tier-migration * 'master' of github.com:elastic/kibana: (34 commits) Line Visualization improper scaling can result in gaps elastic#79663 (elastic#80135) [Security Solution][Timeline] Fix SelectableTimeline search (elastic#80128) move field_mapping util to saved_objects plugin (elastic#79918) [ML] Datagrid: Ensure column content with 'boolean' schema is not capitalized (elastic#80041) [CI] Correctly resolve repository root for JUnit reports (elastic#80226) [Ingest Manager] Fix package upgrade breaking after first rollover before new data has arrived (elastic#79887) [Security Solution] Fix positioning of Kibana banners list inside Sec… (elastic#80124) add missing await to fix test (elastic#80202) Revert test data changed in previous commit. (elastic#79479) [Security Solution] [Sourcerer] Jest beef up (elastic#79907) Re-enable transaction duration alert story (elastic#80187) [npm] remove canvas dep (elastic#80185) [DOCS] Redirects ILM docs to Elasticsearch reference (elastic#79798) [APM] Catch health status error from ML (elastic#80131) Fix layout and remove title for add alert popover. (elastic#77633) [Discover] Loading spinner cleanup (elastic#79819) [Security Solution] [Resolver] Remove related events api (elastic#79036) [Ingest Manager] Remove fields from index pattern during package uninstall (elastic#80082) do not refetch license if signature header absents from a response (elastic#79645) Only send agent data for non-opentelemetry agents (elastic#79587) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/server/routes/api/nodes/register_list_route.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 13, 2020
* upstream/master: (34 commits) Improve vis editor typings (elastic#80004) Line Visualization improper scaling can result in gaps elastic#79663 (elastic#80135) [Security Solution][Timeline] Fix SelectableTimeline search (elastic#80128) move field_mapping util to saved_objects plugin (elastic#79918) [ML] Datagrid: Ensure column content with 'boolean' schema is not capitalized (elastic#80041) [CI] Correctly resolve repository root for JUnit reports (elastic#80226) [Ingest Manager] Fix package upgrade breaking after first rollover before new data has arrived (elastic#79887) [Security Solution] Fix positioning of Kibana banners list inside Sec… (elastic#80124) add missing await to fix test (elastic#80202) Revert test data changed in previous commit. (elastic#79479) [Security Solution] [Sourcerer] Jest beef up (elastic#79907) Re-enable transaction duration alert story (elastic#80187) [npm] remove canvas dep (elastic#80185) [DOCS] Redirects ILM docs to Elasticsearch reference (elastic#79798) [APM] Catch health status error from ML (elastic#80131) Fix layout and remove title for add alert popover. (elastic#77633) [Discover] Loading spinner cleanup (elastic#79819) [Security Solution] [Resolver] Remove related events api (elastic#79036) [Ingest Manager] Remove fields from index pattern during package uninstall (elastic#80082) do not refetch license if signature header absents from a response (elastic#79645) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR overwrites the
.euiDataGridRowCell--booleanclass in the data grid used in ML and replacestext-transform: capitalize;withtext-transform: noneto prevent capitalization of text content.This ensures boolean fields match the suggestions that the search bar autocomplete provides.
Checklist
Delete any items that are not applicable to this PR.