Skip to content

[Telemetry] server fetcher check all collectors ready before sending#79398

Merged
Bamieh merged 5 commits intoelastic:masterfrom
Bamieh:telemetry/check_collectors_ready
Oct 5, 2020
Merged

[Telemetry] server fetcher check all collectors ready before sending#79398
Bamieh merged 5 commits intoelastic:masterfrom
Bamieh:telemetry/check_collectors_ready

Conversation

@Bamieh
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh commented Oct 4, 2020

  • Server fetcher to check all collectors ready before sending

  • Usage fetching failures do not stop server from sending usage (only network issues)

  • Added tests to fully cover sendIfDue function 🎉

related: #79142 (comment)
closes: #79142

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 4, 2020
@Bamieh Bamieh requested a review from a team October 4, 2020 14:46
Copy link
Copy Markdown
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the quick changes!

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit f960e89 into elastic:master Oct 5, 2020
@Bamieh Bamieh deleted the telemetry/check_collectors_ready branch October 5, 2020 13:16
Bamieh added a commit that referenced this pull request Oct 5, 2020
…nding (#79398) (#79461)

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 5, 2020
…nes/fix-description-field

* 'master' of github.com:elastic/kibana:
  A11y tests for user page (elastic#79199)
  [Ingest Pipelines] Processors editor a11y focus states (elastic#79122)
  [Ingest pipelines] Clean up component integration tests (elastic#78838)
  Drilldowns in examples (elastic#75640)
  Storybook and Jest cleanup (elastic#79305)
  adds EQL sequence rule test (elastic#79287)
  PR template a11y checklist item improvement (elastic#79243)
  [Security Solution] Adding tests for dns pipeline in the endpoint package (elastic#79177)
  [ML] Only adjust the bounds of SMV if annotations are visible (elastic#79210)
  global search to ts refs (elastic#79446)
  [Index management] Update TemplateDeserialized interface (elastic#78913)
  [Telemetry] server fetcher check all collectors ready before sending (elastic#79398)
  [Mappings editor] Fix app crash when selecting "other" field type (elastic#79434)
  [`/api/stats`] Add documentation + small improvement (elastic#79330)
  [Discover] "View surrounding documents" encodes spaces in filters (elastic#79283)
  [Lens] refactor DimensionContainer and fix flyout bug (elastic#79277)

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item/inline_text_input.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processors_tree/components/private_tree.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Telemetry] The local strategies should call areAllCollectorsReady

3 participants