Drilldowns in examples#75640
Drilldowns in examples#75640streamich merged 75 commits intoelastic:masterfrom streamich:drilldowns-in-examples
Conversation
|
@elasticmachine merge upstream |
Dosant
left a comment
There was a problem hiding this comment.
Looks good,
-
I think removing
ml/canvasreference in code is a right call, I just think we should finalise it as there are still references, for example, in trigger contexts shapes. -
The example app is so nice. I'd just think we should push descriptions / displayNames / labels a bit further. I don't think anyone would get an idea that apps can register their own triggers and create there own drilldown types for those triggers by just playing with the app. For example: it is not clear that we have different "go to dashboard" implementations from example app.
-
Minor nit, let's at least add description?
Some other asks below. Some of them intersect with points above
x-pack/examples/ui_actions_enhanced_examples/public/triggers/sample_app2_trigger.ts
Show resolved
Hide resolved
x-pack/examples/ui_actions_enhanced_examples/public/triggers/sample_app1_trigger.ts
Show resolved
Hide resolved
...hanced_examples/public/drilldowns/app2_to_dashboard_drilldown/app2_to_dashboard_drilldown.ts
Show resolved
Hide resolved
...examples/ui_actions_enhanced_examples/public/drilldowns/dashboard_to_url_drilldown/index.tsx
Outdated
Show resolved
Hide resolved
...ced/public/services/drilldowns/abstract_dashboard_drilldown/abstract_dashboard_drilldown.tsx
Show resolved
Hide resolved
...lldowns/components/connected_flyout_manage_drilldowns/connected_flyout_manage_drilldowns.tsx
Outdated
Show resolved
Hide resolved
|
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
LGTM, didn't retest latest changes.
One thing: https://github.com/elastic/kibana/pull/75640/files#r498278987 (note about dashboard word in toast)
Or I guess it is fine to change in scope of #78997
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
page load bundle size
History
To update your PR or re-run it, just comment with: |
majagrubic
left a comment
There was a problem hiding this comment.
Had a look at the code, didn't run the examples. kibana-app code looks good to me 👍
Just a few nits I noticed below 👇
...ions_enhanced/public/drilldowns/hooks/use_compatible_action_factories_for_current_context.ts
Show resolved
Hide resolved
x-pack/plugins/ui_actions_enhanced/public/drilldowns/hooks/use_drilldown_state_manager.tsx
Show resolved
Hide resolved
x-pack/plugins/ui_actions_enhanced/public/drilldowns/hooks/use_drilldown_state_manager.tsx
Show resolved
Hide resolved
…nes/fix-description-field * 'master' of github.com:elastic/kibana: A11y tests for user page (elastic#79199) [Ingest Pipelines] Processors editor a11y focus states (elastic#79122) [Ingest pipelines] Clean up component integration tests (elastic#78838) Drilldowns in examples (elastic#75640) Storybook and Jest cleanup (elastic#79305) adds EQL sequence rule test (elastic#79287) PR template a11y checklist item improvement (elastic#79243) [Security Solution] Adding tests for dns pipeline in the endpoint package (elastic#79177) [ML] Only adjust the bounds of SMV if annotations are visible (elastic#79210) global search to ts refs (elastic#79446) [Index management] Update TemplateDeserialized interface (elastic#78913) [Telemetry] server fetcher check all collectors ready before sending (elastic#79398) [Mappings editor] Fix app crash when selecting "other" field type (elastic#79434) [`/api/stats`] Add documentation + small improvement (elastic#79330) [Discover] "View surrounding documents" encodes spaces in filters (elastic#79283) [Lens] refactor DimensionContainer and fix flyout bug (elastic#79277) # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item/inline_text_input.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processors_tree/components/private_tree.tsx
* feat: 🎸 add telemetry for in-chart "Explore underlying data" * feat: 🎸 add telemetry for in-chart "Explore underlying data" * refactor: 💡 move all drilldowns into a sub-folder * feat: 🎸 setup example app section for ui_actions_enhanced * feat: 🎸 set up Drilldown Manager section * feat: 🎸 open drilldown manager from example plugin * refactor: 💡 rename supportedTriggers -> triggers prop * feat: 🎸 show dev warning if triggers prop is empty * refactor: 💡 rename "supportedTriggers" -> "triggers" props * feat: 🎸 open and close drilldown manager from example plugin * feat: 🎸 add sample ML job trigger * feat: 🎸 add sample ML URL drilldown * refactor: 💡 move KibanaURL to share plugin * refactor: 💡 add index file to ml drilldown * feat: 🎸 add AbstractDashboardDrilldown * refactor: 💡 make dashboard drilldown use abstract drilldown * refactor: 💡 rename dashboard drilldown to embeddable drilldown * feat: 🎸 add Dashboard drilldown to sample plugin * feat: 🎸 open dashboard drilldown in list view * feat: 🎸 add drilldown execute button * refactor: 💡 move drilldown React hooks into /hooks folder * test: 💍 fix tests after renaming triggers * chore: 🤖 populate "requireBundles" * fix: 🐛 fix TypeScript errors * fix: 🐛 fix Kibana plugin dependency * chore: 🤖 remoe unused import * feat: 🎸 persist drilldown manager state across app navigations * refactor: 💡 move no-embeddable example into a seprate file * feat: 🎸 set up example with embeddable * feat: 🎸 improve embeddable example * refactor: 💡 rename without embeddable example * feat: 🎸 set up no-embeddable single click example * feat: 🎸 add dashboard drilldown to single button example * fix: 🐛 remove unused margin * fix: 🐛 make "Get more actions" translation static * chore: 🤖 remove old dashboard drilldown definition * refactor: 💡 rename samples to generic names * refactor: 💡 make app 1 example drilldown "hello world" * chore: 🤖 remove unused required bundle * chore: 🤖 add dashboardEnhanced back * [kbn/optimizer] only build xpack examples when building xpack plugins * move alerting_example into x-pack/examples * remove filter for alertingExample plugin in oss plugins CI step * revert unrelated change * fix: 🐛 use correct prop name * test: 💍 fix embeddable-to-dashboard drilldown mock * test: 💍 fix a test after refactor * chore: 🤖 remove unused import * chore: 🤖 add dashboard_enahcned to example plugin * chore: 🤖 address review comments * feat: 🎸 add description to UI Actions Enhanced examples * docs: ✏️ improve docs of example plugin Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Summary
Closes #58027
This PR adds developer examples of Drilldown Manager usage outside of Dashboard app.
go to "Developer examples" -> "UI Actions Enhanced" example plugin.
ui_actions_enhancedplugin.VALUE_CLICK_TRIGGER.