[ML] Update transform cloning to include description and new fields#78364
Merged
qn895 merged 11 commits intoelastic:masterfrom Oct 1, 2020
Merged
[ML] Update transform cloning to include description and new fields#78364qn895 merged 11 commits intoelastic:masterfrom
qn895 merged 11 commits intoelastic:masterfrom
Conversation
[ML] Clean up console
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested and looks good.
Looks like the cloning transform functional test needs an edit too as the description is now cloned. I think it will be worth adding another test in, checking that the advanced properties (frequency and max page search size) are cloned as expected.
walterra
reviewed
Sep 28, 2020
peteharverson
approved these changes
Sep 28, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
LGTM with extra functional tests added.
walterra
reviewed
Sep 29, 2020
walterra
reviewed
Sep 29, 2020
Contributor
|
It would be great if you can add some updated tests for |
Member
Author
Member
|
Checked test stability in a flaky test runner job: no failure in 50 runs ✔️ |
…ne-fields # Conflicts: # x-pack/test/functional/apps/ml/settings/index.ts
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Oct 1, 2020
qn895
added a commit
that referenced
this pull request
Oct 1, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Oct 1, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (76 commits) Fix z-index of KQL Suggestions dropdown (elastic#79184) [babel] remove unused/unneeded babel plugins (elastic#79173) [Search] Fix timeout upgrade link (elastic#79045) Always Show Embeddable Panel Header in Edit Mode (elastic#79152) [Ingest]: add more test for transform index (elastic#79154) [ML] DF Analytics: Collapsable sections on results pages (elastic#76641) [Fleet] Fix agent policy change action migration (elastic#79046) [Ingest Manager] Match package spec `dataset`->`data_stream` and `config_templates`->`policy_templates` renaming (elastic#78699) Revert "[Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875)" [ML] Update transform cloning to include description and new fields (elastic#78364) chore(NA): remove non existing plugin paths from case api integration tests (elastic#79127) [Ingest Manager] Ensure we trigger agent policy updated event when we bump revision. (elastic#78836) [Metrics UI] Display No Data context.values as [NO DATA] (elastic#78038) [Monitoring] Missing data alert (elastic#78208) [Lens] Fix embeddable title and description for reporting and dashboard tooltip (elastic#78767) [Lens] Consistent Drag and Drop styles (elastic#78674) [ML] Model management UI fixes and enhancements (elastic#79072) [Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875) [Security Solution]Fix basepath used by endpoint telemetry tests (elastic#79027) update rum agent version which contains longtasks (elastic#79105) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #75264. Cloning a transform should now carry over the
description,frequency,settings.max_page_search_size, andsettings.docs_per_sec.