[Maps] lazy load maps_legacy, tile_map, and region_map bundle#78027
Merged
nreese merged 11 commits intoelastic:masterfrom Sep 24, 2020
Merged
[Maps] lazy load maps_legacy, tile_map, and region_map bundle#78027nreese merged 11 commits intoelastic:masterfrom
nreese merged 11 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
code review, tested.
really impressive improvement 🧨
Just one suggestion. Don't feel strongly, but might improve readability and help users distinguish between "modules" and instance-vars.
Contributor
Author
I have remove _leaflet and _serviceSettings from BaseMapsVisualization |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
This was referenced Sep 24, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 24, 2020
…c#78027) * [Maps] lazy load maps_legacy bundle * tslint * lazy load leaflet * try to get lodash out of maps_legacy bundle and work on tile_map bundle * lazy load service settings * lazy load region_map and fix vega unit tests * tslint fixes * remove lodash from region_map bundle * review feedback * remove unused file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Sep 24, 2020
#78480) * [Maps] lazy load maps_legacy bundle * tslint * lazy load leaflet * try to get lodash out of maps_legacy bundle and work on tile_map bundle * lazy load service settings * lazy load region_map and fix vega unit tests * tslint fixes * remove lodash from region_map bundle * review feedback * remove unused file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Nov 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #78022
This PR creates a lazy load bundle for maps_legacy, region_map, and tile_map to reduce plugin size.