Skip to content

[7.x] [Maps] lazy load maps_legacy, tile_map, and region_map bundle (#78027)#78480

Merged
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-78027
Sep 24, 2020
Merged

[7.x] [Maps] lazy load maps_legacy, tile_map, and region_map bundle (#78027)#78480
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-78027

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Sep 24, 2020

Backports the following commits to 7.x:

…c#78027)

* [Maps] lazy load maps_legacy bundle

* tslint

* lazy load leaflet

* try to get lodash out of maps_legacy bundle and work on tile_map bundle

* lazy load service settings

* lazy load region_map and fix vega unit tests

* tslint fixes

* remove lodash from region_map bundle

* review feedback

* remove unused file

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese added the backport This PR is a backport of another PR label Sep 24, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
mapsLegacy 143 +4 139

async chunks size

id value diff baseline
mapsLegacy 723.4KB ⚠️ +723.4KB 0.0B
regionMap 264.6KB ⚠️ +264.6KB 0.0B
tileMap 273.9KB ⚠️ +273.9KB 0.0B
visTypeVega 1.4MB +515.0B 1.4MB
total ⚠️ +1.2MB

page load bundle size

id value diff baseline
mapsLegacy 96.5KB -719.7KB 816.2KB
mapsLegacyLicensing 5.1KB +966.0B 4.1KB
regionMap 44.9KB -258.0KB 302.9KB
tileMap 44.9KB -269.7KB 314.7KB
visTypeVega 134.2KB -403.0B 134.6KB
total -1.2MB

distributable file count

id value diff baseline
default 47342 +18 47324
oss 28056 +18 28038
total +36

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit c15bb39 into elastic:7.x Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants