Merged
Conversation
Contributor
Author
|
Blocked by #76054, as the legacy |
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
commented
Sep 17, 2020
Comment on lines
11
to
13
| export interface AppServerPluginDependencies { | ||
| licensing: LicensingPluginSetup; | ||
| elasticsearch: ElasticsearchPlugin; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This was actually unused, I just removed it from the interface
Comment on lines
-9
to
+10
|
|
||
| import { DeprecationInfo } from 'src/legacy/core_plugins/elasticsearch'; | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| import type { DeprecationInfo } from '../../../../../../../../src/core/server/elasticsearch/legacy/api_types'; |
Contributor
Author
There was a problem hiding this comment.
There was a few references to DeprecationInfo in the upgrade_assistant plugin. To avoid exporting additional deprecated types from core, and knowing that the legacy client is deprecated anyway, I used the internal path instead.
watson
approved these changes
Sep 17, 2020
Contributor
watson
left a comment
There was a problem hiding this comment.
Kibana Security changes LGTM 👍
3 tasks
afharo
approved these changes
Sep 17, 2020
Member
afharo
left a comment
There was a problem hiding this comment.
Telemetry changes LGTM!
(type change in x-pack/plugins/telemetry_collection_xpack/server/telemetry_collection/get_xpack.ts)
walterra
approved these changes
Sep 17, 2020
Contributor
walterra
left a comment
There was a problem hiding this comment.
ML/Transform changes LGTM
cjcenizal
approved these changes
Sep 17, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Rollup, Search Profiler, and UA code LGTM, didn't test locally.
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Sep 18, 2020
* remove legacy ES plug * fix types * delete some `legacy/core_plugins` references * fix type # Conflicts: # .github/CODEOWNERS # src/legacy/core_plugins/elasticsearch/index.js # src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.js # src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.test.js # src/legacy/core_plugins/elasticsearch/lib/cluster.ts # src/legacy/core_plugins/elasticsearch/lib/create_proxy.js # x-pack/dev-tools/jest/create_jest_config.js
pgayvallet
added a commit
that referenced
this pull request
Sep 18, 2020
* remove legacy ES plugin (#77703) * remove legacy ES plug * fix types * delete some `legacy/core_plugins` references * fix type # Conflicts: # .github/CODEOWNERS # src/legacy/core_plugins/elasticsearch/index.js # src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.js # src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.test.js # src/legacy/core_plugins/elasticsearch/lib/cluster.ts # src/legacy/core_plugins/elasticsearch/lib/create_proxy.js # x-pack/dev-tools/jest/create_jest_config.js * remove unused legacy file from 7.x
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (92 commits) [ILM] Data tiers for 7.10 (elastic#76126) [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789) [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654) Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746) [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598) [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688) fixed react warning in Suspense in alert flyout (elastic#77777) [APM] Track usage of Gold+ features (elastic#77630) Visualize: Bad request when working with histogram aggregation (elastic#77684) remove legacy ES plugin (elastic#77703) [Lens] change name of custom query to filters (elastic#77725) skip flaky suite (elastic#76239) remove visual aspects of baseline job (elastic#77815) skip flaky suite (elastic#77835) Fixes typo in data recognizer text (elastic#77691) management/update trusted_apps jest snapshot [build] Use Elastic hosted UBI minimal base image (elastic#77776) [APM] Add transaction error rate alert (elastic#76933) [Security Solution] [Detections] Remove file validation on import route (elastic#77770) [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #71927
src/legacy/core_plugins