Visualize: Bad request when working with histogram aggregation#77684
Merged
alexwizp merged 4 commits intoelastic:masterfrom Sep 18, 2020
Merged
Visualize: Bad request when working with histogram aggregation#77684alexwizp merged 4 commits intoelastic:masterfrom
alexwizp merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Code here makes sense, but we should also add unit and/or functional tests for this case. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Removed myself as reviewer as I contributed to the PR 😅 |
lukeelmers
approved these changes
Sep 17, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Updates LGTM, thanks for adding that test!
Tested on chrome (macOS), and seems to be working as expected
stratoula
approved these changes
Sep 18, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
LGTM, tested on safari
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Sep 18, 2020
…ic#77684) * Visualize: Bad request when working with histogram aggregation Closes: elastic#77023 * ✏️ Add some more fix context * ✅ Add test Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Sep 18, 2020
… (#77850) * Visualize: Bad request when working with histogram aggregation Closes: #77023 * ✏️ Add some more fix context * ✅ Add test Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (92 commits) [ILM] Data tiers for 7.10 (elastic#76126) [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789) [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654) Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746) [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598) [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688) fixed react warning in Suspense in alert flyout (elastic#77777) [APM] Track usage of Gold+ features (elastic#77630) Visualize: Bad request when working with histogram aggregation (elastic#77684) remove legacy ES plugin (elastic#77703) [Lens] change name of custom query to filters (elastic#77725) skip flaky suite (elastic#76239) remove visual aspects of baseline job (elastic#77815) skip flaky suite (elastic#77835) Fixes typo in data recognizer text (elastic#77691) management/update trusted_apps jest snapshot [build] Use Elastic hosted UBI minimal base image (elastic#77776) [APM] Add transaction error rate alert (elastic#76933) [Security Solution] [Detections] Remove file validation on import route (elastic#77770) [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #77023
Summary
When changing the settings for the histogram aggregation, it's possible to run into a state no interval is provided
Steps to reproduce:
Checklist
Delete any items that are not applicable to this PR.
For maintainers