Skip to content

[CSM Dashboard] Remove points from line chart#77617

Merged
shahzad31 merged 8 commits intoelastic:masterfrom
shahzad31:use-simple-line-curve
Sep 17, 2020
Merged

[CSM Dashboard] Remove points from line chart#77617
shahzad31 merged 8 commits intoelastic:masterfrom
shahzad31:use-simple-line-curve

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented Sep 16, 2020 •
edited
Loading

Summary

Fixes #77612

  • Removed points from line chart
  • Also fixed a small bug where user was unable to unselect breakdown
  • Also on server abstracted a common logic into a function

image

@shahzad31 shahzad31 self-assigned this Sep 16, 2020
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Sep 16, 2020
@shahzad31 shahzad31 marked this pull request as ready for review September 16, 2020 14:52
@shahzad31 shahzad31 requested a review from a team as a code owner September 16, 2020 14:52
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 16, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 16, 2020

Pinging @elastic/apm-ui (Team:apm)

justinkambic
justinkambic approved these changes Sep 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally, code review. Fixes look good, no points is much nicer too.

EDIT: WFG

@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented Sep 16, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 17, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 5.0MB +202.0B 5.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 5be36b7 into elastic:master Sep 17, 2020
@shahzad31 shahzad31 deleted the use-simple-line-curve branch September 17, 2020 11:02
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 18, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
6a85bac 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (140 commits)
  Add telemetry as an automatic privilege grant (elastic#77390)
  [Security Solutions][Cases] Cases Redesign (elastic#73247)
  Use Search API in TSVB (elastic#76274)
  [Mappings editor] Add support for constant_keyword field type (elastic#76564)
  [ML] Adds ML modules for Metrics UI Integration (elastic#76460)
  [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771)
  Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054)
  use App updater API instead of deprecated chrome.navLinks.update (elastic#77708)
  [CSM Dashboard] Remove points from line chart (elastic#77617)
  [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470)
  [Observability] Overview: Alerts section style improvements (elastic#77670)
  Bump the Node.js version used by Docker in CI (elastic#77714)
  Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284)
  Remove unneeded forced package resolutions (elastic#77467)
  [ML] Add metrics app to check made for internal custom URLs (elastic#77627)
  Functional tests - add supertest for test_user (elastic#77584)
  [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484)
  Bump node-fetch to 2.6.1 (elastic#77445)
  Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607)
  [APM]fixing y axis on transaction error rate to 100% (elastic#77609)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
@shahzad31 shahzad31 mentioned this pull request Sep 18, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 18, 2020
@shahzad31 @elasticmachine
[CSM Dashboard] Remove points from line chart (elastic#77617)
6f18f90 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31 added a commit that referenced this pull request Sep 18, 2020
@shahzad31 @elasticmachine
[CSM Dashboard] Remove points from line chart (#77617) (#77920)
66f173f 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sorenlouv sorenlouv removed the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CSM Dashboard] Hide line points on page load dist chart

5 participants

@shahzad31 @elasticmachine @kibanamachine @justinkambic @sorenlouv