Skip to content

Functional tests - add supertest for test_user#77584

Merged
pheyos merged 1 commit intoelastic:masterfrom
pheyos:test_user_supertest
Sep 17, 2020
Merged

Functional tests - add supertest for test_user#77584
pheyos merged 1 commit intoelastic:masterfrom
pheyos:test_user_supertest

Conversation

@pheyos
Copy link
Copy Markdown
Member

@pheyos pheyos commented Sep 16, 2020 •
edited
Loading

Summary

This PR adds a supertest instance that runs with test_user permissions to the security service.

Details

This basically addresses two items:

  1. Currently, the dashboard and visualize reporting tests are failing on cloud
  2. The reporting_page code currently contains hard-coded credentials:
const auth = 'test_user:changeme'; // FIXME not sure why there is no config that can be read for this

Closes #68848
Closes #68851

@pheyos pheyos self-assigned this Sep 16, 2020
@pheyos pheyos added the release_note:skip Skip the PR/issue when compiling release notes label Sep 16, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 16, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Sep 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this

@rashmivkulkarni
Copy link
Copy Markdown
Contributor

rashmivkulkarni commented Sep 16, 2020

LGTM - code review only .

@pheyos pheyos merged commit 5f19be5 into elastic:master Sep 17, 2020
@pheyos pheyos deleted the test_user_supertest branch September 17, 2020 08:42
@pheyos pheyos mentioned this pull request Sep 17, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Sep 17, 2020
@pheyos
Functional tests - add supertest for test_user (elastic#77584)
cb1d7dd 
This PR adds a supertest instance that runs with test_user permissions to the security service.
pheyos added a commit that referenced this pull request Sep 17, 2020
@pheyos
Functional tests - add supertest for test_user (#77584) (#77723)
832ebb0 
This PR adds a supertest instance that runs with test_user permissions to the security service.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 18, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
6a85bac 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (140 commits)
  Add telemetry as an automatic privilege grant (elastic#77390)
  [Security Solutions][Cases] Cases Redesign (elastic#73247)
  Use Search API in TSVB (elastic#76274)
  [Mappings editor] Add support for constant_keyword field type (elastic#76564)
  [ML] Adds ML modules for Metrics UI Integration (elastic#76460)
  [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771)
  Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054)
  use App updater API instead of deprecated chrome.navLinks.update (elastic#77708)
  [CSM Dashboard] Remove points from line chart (elastic#77617)
  [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470)
  [Observability] Overview: Alerts section style improvements (elastic#77670)
  Bump the Node.js version used by Docker in CI (elastic#77714)
  Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284)
  Remove unneeded forced package resolutions (elastic#77467)
  [ML] Add metrics app to check made for internal custom URLs (elastic#77627)
  Functional tests - add supertest for test_user (elastic#77584)
  [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484)
  Bump node-fetch to 2.6.1 (elastic#77445)
  Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607)
  [APM]fixing y axis on transaction error rate to 100% (elastic#77609)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment