Separate url forwarding logic and legacy services#76892
Merged
flash1293 merged 9 commits intoelastic:masterfrom Sep 14, 2020
Merged
Separate url forwarding logic and legacy services#76892flash1293 merged 9 commits intoelastic:masterfrom
flash1293 merged 9 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mshustov
approved these changes
Sep 8, 2020
Contributor
mshustov
left a comment
There was a problem hiding this comment.
ok for Migration.md changes
lizozom
approved these changes
Sep 8, 2020
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Code owner change is moving migrateLegacyQuery into the data plugin.
LGTM
chrisronline
approved these changes
Sep 8, 2020
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
LGTM for stack monitoring
cjcenizal
approved these changes
Sep 8, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Change to Dev Tools LGTM, didn't test locally.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
kertal
approved these changes
Sep 14, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, KibanaApp code owner review, tested locally in Firefox / Chrome, redirects and migration of legacy URLs work 👍
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Sep 14, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 14, 2020
…s-for-710 * 'master' of github.com:elastic/kibana: (65 commits) Separate url forwarding logic and legacy services (elastic#76892) Bump yargs-parser to v13.1.2+ (elastic#77009) [Ingest Manager] Shared Fleet agent policy action (elastic#76013) [Search] Re-add support for aborting when a connection is closed (elastic#76470) [Search] Remove long-running query pop-up (elastic#75385) [Monitoring] Fix UI error when alerting is not available (elastic#77179) do not log plugin id format warning in dist mode (elastic#77134) [ML] Improving client side error handling (elastic#76743) [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357) [Docs] some basic searchsource api docs (elastic#77038) add cGroupOverrides to the legacy config (elastic#77180) Change saved object bulkUpdate to work across multiple namespaces (elastic#75478) [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997) Removing ml-state index from archive (elastic#77143) [Security Solution] Add unit tests for histograms (elastic#77081) [Lens] Filters aggregation (elastic#75635) [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122) Cleanup type output before building new types (elastic#77211) [Security Solution] Use safe type in resolver backend (elastic#76969) Use proper lodash syntax (elastic#77105) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
flash1293
added a commit
that referenced
this pull request
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69133
urlForwarding- will stick around forever, possibly including related functionality later onkibanaLegacy- will be removed as soon as the last consumer is doneThis PR separates the parts to keep (legacy url forwarding) from the parts to migrate away from mid-term. It cleans up two questionable dependencies right away:
migrateLegacyQueryhelper into the places it's used (data, visualize, discover, dashboard) - it doesn't really fit anywhere and we did the same for the dotted string helperkbnBaseUrlwith the home url in the monitoring plugin