[Search] Remove long-running query pop-up by lukasolson · Pull Request #75385 · elastic/kibana

lukasolson · 2020-08-19T02:11:37Z

Summary

Resolves #75356.

This PR removes the long-running query pop-up that shows up after 15 seconds and prompts the user to run beyond timeout. This will be replaced by a configuration value that administrators can control for async search requests explained here: #75321

Checklist

Functional tests

(Release notes will be added in the PR that adds the new advanced setting.)

elasticmachine · 2020-08-19T02:11:40Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

lizozom · 2020-08-20T08:26:01Z

@elasticmachine merge upstream

elasticmachine · 2020-08-20T08:26:03Z

ignoring request to update branch, pull request is closed

lizozom · 2020-08-20T08:26:27Z

@elasticmachine merge upstream

src/plugins/data/public/search/collectors/create_usage_collector.ts

src/plugins/data/public/search/search_interceptor.ts

lizozom · 2020-08-23T10:56:55Z

@elasticmachine merge upstream

lizozom · 2020-08-23T10:58:25Z

src/plugins/data/public/search/search_interceptor.ts

    const { signal: timeoutSignal } = timeoutController;
-    const timeout$ = timer(this.requestTimeout);
+    const timeout$ =
+      this.requestTimeout != null && this.requestTimeout > 0 ? timer(this.requestTimeout) : NEVER;


//nit

this.requestTimeout != null && this.requestTimeout > 0 ➡️ !this.requestTimeout ?

I'm not sure I understand, could you provide the code snippet?

lizozom

I think we can go ahead and merge it, adding tests once the delayed agg is available.
LGTM

lizozom · 2020-08-23T15:02:07Z

After thinking some more about it, I think that the search interceptor should still be responsible for showing the timeout toast.
The reasoning behind is that we're going to have different types of notifications per-license and permissions, and I think it could be convenient if those were handled in one place.

Alternatively, we could provide a component that is called by the solution and shows the correct message.

Lets talk about it.

…cedSearchInterceptor

…-timeout-setting

…bana into search/search-timeout-setting

…-timeout-setting

lizozom · 2020-09-09T12:07:46Z

@elasticmachine merge upstream

lizozom · 2020-09-10T08:06:20Z

x-pack/plugins/data_enhanced/public/search/search_interceptor.ts

+  // error notification per session.
+  protected showTimeoutError = debounce(
+    (e: Error) => {
+      const message = this.application.capabilities.advancedSettings?.save


All strings need to be translated

…-remove-popup

kibanamachine · 2020-09-13T17:14:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 66dac98

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
data	541	-1	542
dataEnhanced	20	-1	21
total		-2

page load bundle size

id	value	diff	baseline
data	1.4MB	-5.0KB	1.4MB
dataEnhanced	177.1KB	-1.6KB	178.8KB
total		-6.6KB

History

💔 Build #73895 failed 4ed7d31
💚 Build #73350 succeeded bc6eaae
💛 Build #73323 was flaky 25d5e37
💔 Build #73312 failed 069390b
💚 Build #73086 succeeded 790f2b0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [Search] Remove long-running query pop-up * Don't timeout if requestTimeout isn't configured * Remove unused kibanaUtils * Remove unused kibanaReact * Re-add reference to kibanaUtils * Remove unused translations and update documentation * Add new x-pack advanced setting searchTimeout and use it in the EnhancedSearchInterceptor * docs * Re-add toast when queries time out * Fix types * Update error message with capabilities * Update docs * Update docs * Move search server routes into a directory. * Add internal/_msearch route. * Remove legacy search API, rewrite default search strategy to use internal route. * Remove legacy es_client code. * Handle msearch options on server. * Remove elasticsearch-browser dependency. * Update generated docs. * Rely on server timeout in OSS (?) Use UI setting in xpack. * Rename function * Add features to dependencies * Undefined check * doc * Code review fixes * code review * doc * loading count * simplify code review and fix jest tets * type check * Remove esShard from client * cleanup request parameters from FE * doc * doc * Align request parameters on server, Remove leftover parameters from client Shim responses for search and msearch routes * docs Stop using toSnakeCase Updates jest tests * add management docs * docs * Remove import * Break circular dep + fix msearch test * Remove deleted type * Fix jest * Bring toSnakeCase back * docs * fix jest * Add new x-pack advanced setting searchTimeout and use it in the EnhancedSearchInterceptor * docs * Rely on server timeout in OSS (?) Use UI setting in xpack. * Rename function * doc * Remove esShard from client * cleanup request parameters from FE * doc * doc * Align request parameters on server, Remove leftover parameters from client Shim responses for search and msearch routes * docs Stop using toSnakeCase Updates jest tests * add management docs * docs * Remove import * Break circular dep + fix msearch test * Remove deleted type * Fix jest * Bring toSnakeCase back * docs * fix jest * Fix merge * Fix types * Allow timeout to be undefined * Fix jest test * Upldate docs * Fix msearch jest * Merge correction * docs * Fix rollup search merge * Fix merge * Use i18n Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [Search] Remove long-running query pop-up * Don't timeout if requestTimeout isn't configured * Remove unused kibanaUtils * Remove unused kibanaReact * Re-add reference to kibanaUtils * Remove unused translations and update documentation * Add new x-pack advanced setting searchTimeout and use it in the EnhancedSearchInterceptor * docs * Re-add toast when queries time out * Fix types * Update error message with capabilities * Update docs * Update docs * Move search server routes into a directory. * Add internal/_msearch route. * Remove legacy search API, rewrite default search strategy to use internal route. * Remove legacy es_client code. * Handle msearch options on server. * Remove elasticsearch-browser dependency. * Update generated docs. * Rely on server timeout in OSS (?) Use UI setting in xpack. * Rename function * Add features to dependencies * Undefined check * doc * Code review fixes * code review * doc * loading count * simplify code review and fix jest tets * type check * Remove esShard from client * cleanup request parameters from FE * doc * doc * Align request parameters on server, Remove leftover parameters from client Shim responses for search and msearch routes * docs Stop using toSnakeCase Updates jest tests * add management docs * docs * Remove import * Break circular dep + fix msearch test * Remove deleted type * Fix jest * Bring toSnakeCase back * docs * fix jest * Add new x-pack advanced setting searchTimeout and use it in the EnhancedSearchInterceptor * docs * Rely on server timeout in OSS (?) Use UI setting in xpack. * Rename function * doc * Remove esShard from client * cleanup request parameters from FE * doc * doc * Align request parameters on server, Remove leftover parameters from client Shim responses for search and msearch routes * docs Stop using toSnakeCase Updates jest tests * add management docs * docs * Remove import * Break circular dep + fix msearch test * Remove deleted type * Fix jest * Bring toSnakeCase back * docs * fix jest * Fix merge * Fix types * Allow timeout to be undefined * Fix jest test * Upldate docs * Fix msearch jest * Merge correction * docs * Fix rollup search merge * Fix merge * Use i18n Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…s-for-710 * 'master' of github.com:elastic/kibana: (65 commits) Separate url forwarding logic and legacy services (elastic#76892) Bump yargs-parser to v13.1.2+ (elastic#77009) [Ingest Manager] Shared Fleet agent policy action (elastic#76013) [Search] Re-add support for aborting when a connection is closed (elastic#76470) [Search] Remove long-running query pop-up (elastic#75385) [Monitoring] Fix UI error when alerting is not available (elastic#77179) do not log plugin id format warning in dist mode (elastic#77134) [ML] Improving client side error handling (elastic#76743) [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357) [Docs] some basic searchsource api docs (elastic#77038) add cGroupOverrides to the legacy config (elastic#77180) Change saved object bulkUpdate to work across multiple namespaces (elastic#75478) [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997) Removing ml-state index from archive (elastic#77143) [Security Solution] Add unit tests for histograms (elastic#77081) [Lens] Filters aggregation (elastic#75635) [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122) Cleanup type output before building new types (elastic#77211) [Security Solution] Use safe type in resolver backend (elastic#76969) Use proper lodash syntax (elastic#77105) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx

[Search] Remove long-running query pop-up

9ce2275

lukasolson added Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 19, 2020

lukasolson requested a review from a team as a code owner August 19, 2020 02:11

lukasolson self-assigned this Aug 19, 2020

lizozom closed this Aug 20, 2020

lizozom reopened this Aug 20, 2020

lizozom reviewed Aug 20, 2020

View reviewed changes

src/plugins/data/public/search/collectors/create_usage_collector.ts Outdated Show resolved Hide resolved

src/plugins/data/public/search/search_interceptor.ts Outdated Show resolved Hide resolved

lukasolson added 2 commits August 20, 2020 11:17

Merge branch 'master' into search-remove-popup

b647c34

Don't timeout if requestTimeout isn't configured

c1217b0

lukasolson force-pushed the search-remove-popup branch from 666cd7f to c1217b0 Compare August 20, 2020 18:27

lukasolson added 5 commits August 20, 2020 15:44

Merge branch 'master' into search-remove-popup

3299406

Remove unused kibanaUtils

b9aa07d

Remove unused kibanaReact

c2c0237

Re-add reference to kibanaUtils

7927af6

Remove unused translations and update documentation

0f69bac

lizozom reviewed Aug 23, 2020

View reviewed changes

lizozom approved these changes Aug 23, 2020

View reviewed changes

Add new x-pack advanced setting searchTimeout and use it in the Enhan…

c29ab1b

…cedSearchInterceptor

lizozom mentioned this pull request Aug 23, 2020

[Search] Add a new advanced setting searchTimeout #75728

Merged

7 tasks

docs

4f603ce

Liza K and others added 4 commits September 6, 2020 14:12

Fix msearch jest

882c4fd

Merge branch 'search/search-timeout-setting' into pr/75385

6e91b8f

Merge correction

95f0e9b

Merge branch 'master' into search/search-timeout-setting

b9306c0

pgayvallet approved these changes Sep 7, 2020

View reviewed changes

lizozom mentioned this pull request Sep 7, 2020

[Search] Client side session service #76889

Merged

7 tasks

Liza K added 8 commits September 7, 2020 19:58

Merge branch 'master' of github.com:elastic/kibana into search/search…

bec86a5

…-timeout-setting

docs

887b3ea

Merge branch 'search/search-timeout-setting' of github.com:lizozom/ki…

b9c7dfc

…bana into search/search-timeout-setting

Merge branch 'master' of github.com:elastic/kibana into search/search…

4bdbcc6

…-timeout-setting

Merge branch 'master' of github.com:elastic/kibana into search/search…

f6d4b5b

…-timeout-setting

Fix rollup search merge

4405680

Merge branch 'master' of github.com:elastic/kibana into search/search…

61d1f76

…-timeout-setting

Merge branch 'search/search-timeout-setting' into pr/75385

790f2b0

lizozom removed the request for review from a team September 8, 2020 17:08

Liza K added 2 commits September 9, 2020 10:45

Merge branch 'master' of github.com:elastic/kibana into pr/75385

069390b

Fix merge

25d5e37

Merge branch 'master' into search-remove-popup

bc6eaae

lizozom removed the request for review from a team September 10, 2020 07:42

lizozom reviewed Sep 10, 2020

View reviewed changes

lukasolson added 3 commits September 10, 2020 15:47

Use i18n

c6508b0

Merge remote-tracking branch 'origin/search-remove-popup' into search…

4ed7d31

…-remove-popup

Merge branch 'master' into search-remove-popup

66dac98

lukasolson merged commit b99d8af into elastic:master Sep 13, 2020

lukasolson mentioned this pull request Sep 13, 2020

[7.x] [Search] Remove long-running query pop-up (#75385) #77294

Merged

Conversation

lukasolson commented Aug 19, 2020

Summary

Checklist

Uh oh!

elasticmachine commented Aug 19, 2020

Uh oh!

lizozom commented Aug 20, 2020

Uh oh!

elasticmachine commented Aug 20, 2020

Uh oh!

lizozom commented Aug 20, 2020

Uh oh!

Uh oh!

Uh oh!

lizozom commented Aug 23, 2020

Uh oh!

lizozom Aug 23, 2020

Choose a reason for hiding this comment

Uh oh!

lukasolson Aug 24, 2020

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom commented Aug 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lizozom commented Sep 9, 2020

Uh oh!

lizozom Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 13, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lizozom commented Aug 23, 2020 •

edited

Loading