Replace FetchOptions with ISearchOptions#76538
Merged
lizozom merged 3 commits intoelastic:masterfrom Sep 3, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
patrykkopycinski
approved these changes
Sep 2, 2020
Contributor
patrykkopycinski
left a comment
There was a problem hiding this comment.
SIEM changes LGTM! Thank you @lizozom 💪
lizozom
commented
Sep 2, 2020
lukeelmers
approved these changes
Sep 2, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Code changes here LGTM. Should we also update the dev docs issue to indicate that signal has been renamed abortSignal?
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Sep 3, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
KibanaApp owned code LGTM, just one file containing the rename of signal -> `abortSignal, didn't test
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Sep 3, 2020
* Replace FetchOptions with ISearchOptions and update usage * Merge the client and server ISearchOption types into common * docs
lizozom
added a commit
that referenced
this pull request
Sep 3, 2020
* Replace FetchOptions with ISearchOptions (#76538) * Replace FetchOptions with ISearchOptions and update usage * Merge the client and server ISearchOption types into common * docs * Update index.tsx Abort signal * Update index.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 3, 2020
…nes/processors-forms-k-s * 'master' of github.com:elastic/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processor_settings_fields.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 3, 2020
…oleysens/kibana into ingest-pipelines/processors-forms-k-s * 'ingest-pipelines/processors-forms-k-s' of github.com:jloleysens/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISearchOptionsinto thecommonfolder. The type is still re-exported from both thepublicandserverfolders.FetchOptions(Used bySearchSource) withISearchOptions(Used by thesearchAPI) and update usage.This was done in order to simplify adding new options to
SearchSourceandsearchapis.Dev Docs
The
FetchOptionstype was removed, use theISearchOptionstype instead.The
ISearchOptionssignaloption was renamed toabortSignal.Checklist
Delete any items that are not applicable to this PR.
For maintainers