Skip to content

[Ingest Manager] Wording & linking improvements#76284

Merged
skh merged 3 commits intoelastic:masterfrom
skh:75807-text-links-improvements-2
Sep 3, 2020
Merged

[Ingest Manager] Wording & linking improvements#76284
skh merged 3 commits intoelastic:masterfrom
skh:75807-text-links-improvements-2

Conversation

@skh
Copy link
Copy Markdown
Contributor

@skh skh commented Aug 31, 2020

Summary

Partially implements #75807 .

Changes

In the "add agent" flyout, if fleet hasn't been enabled yet, move the "Go to fleet" link to "set up fleet" in the preceding sentence

Before:

image

After:

image


Add some explanatory text to the top of the "add agent" flyout:

Before:

image

After:

image


On the standalone tab of the "add agent" flyout, add a link to the data streams page:

Before:

image

After:

image

@skh skh changed the title Improve wording on add agent flyout. [Ingest Manager] Wording & linking improvements Aug 31, 2020
@skh skh force-pushed the 75807-text-links-improvements-2 branch from 21360a7 to 97ce531 Compare September 2, 2020 10:33
@skh skh self-assigned this Sep 2, 2020
@skh skh added Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0 labels Sep 2, 2020
@skh skh marked this pull request as ready for review September 2, 2020 12:48
@skh skh requested a review from a team September 2, 2020 12:48
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Feature:Fleet)

@skh skh requested a review from hbharding September 2, 2020 12:48
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestManager 1.1MB +991.0B 1.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@skh skh merged commit ebc50e6 into elastic:master Sep 3, 2020
skh added a commit to skh/kibana that referenced this pull request Sep 3, 2020
* Improve wording on add agent flyout.

* Add agent explanation to agent flyout.

* Add link to data stream page.
skh added a commit that referenced this pull request Sep 3, 2020
* Improve wording on add agent flyout.

* Add agent explanation to agent flyout.

* Add link to data stream page.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2020
…nes/processors-forms-k-s

* 'master' of github.com:elastic/kibana: (216 commits)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  Replace FetchOptions with ISearchOptions (elastic#76538)
  Move streams utils to the core  (elastic#76397)
  [Ingest Manager] Wording & linking improvements (elastic#76284)
  remove legacy kibana plugin (elastic#76064)
  [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379)
  Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482)
  [APM] Service maps layout enhancements (elastic#76481)
  [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586)
  [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544)
  Index Pattern class - remove toJSON and toString (elastic#76246)
  skip failing suite (elastic#76581)
  Split up and clarify Enterprise Search codeowners (elastic#76580)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processor_settings_fields.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2020
…oleysens/kibana into ingest-pipelines/processors-forms-k-s

* 'ingest-pipelines/processors-forms-k-s' of github.com:jloleysens/kibana: (216 commits)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  Replace FetchOptions with ISearchOptions (elastic#76538)
  Move streams utils to the core  (elastic#76397)
  [Ingest Manager] Wording & linking improvements (elastic#76284)
  remove legacy kibana plugin (elastic#76064)
  [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379)
  Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482)
  [APM] Service maps layout enhancements (elastic#76481)
  [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586)
  [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544)
  Index Pattern class - remove toJSON and toString (elastic#76246)
  skip failing suite (elastic#76581)
  Split up and clarify Enterprise Search codeowners (elastic#76580)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants