[Uptime] Modify router to use `ScopedHistory` by justinkambic · Pull Request #76421 · elastic/kibana

justinkambic · 2020-09-01T18:36:39Z

Summary

Fixes #76348.

Removes the usage of BrowserRouter and reliance on hashbang routing.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-09-01T18:36:41Z

Pinging @elastic/uptime (Team:uptime)

pgayvallet

LGTM. Thanks for handling this that quickly.

shahzad31 · 2020-09-02T07:38:43Z

x-pack/plugins/uptime/public/apps/plugin.ts


    core.application.register({
-      appRoute: '/app/uptime#/',
+      appRoute: '/app/uptime',


this optional btw, platform will generate default route. So we can remove this.

Thanks for pointing this out. I removed it c3fa61b.

shahzad31

It breaks the breadcrumb behaviour clicking uptime from details page trigger full reload.

justinkambic · 2020-09-02T12:40:28Z

It breaks the breadcrumb behaviour clicking uptime from details page trigger full reload.

Glad you noticed this too, any idea what's causing the behavior? I'm having trouble isolating it.

justinkambic · 2020-09-02T13:27:56Z

@shahzad31 give it another look I did something similar to APM's solution to this problem: 0e4ff0a

justinkambic · 2020-09-02T20:32:32Z

@elasticmachine merge upstream

shahzad31 · 2020-09-03T10:43:26Z

All looks good, but this last thing can you please see why details page breadcrumb is adding this flag to url

…ana into uptime_hashbang-removal

justinkambic · 2020-09-03T14:45:47Z

@shahzad31 give it another look, I think all is well now.

justinkambic · 2020-09-04T17:50:19Z

@elasticmachine merge upstream

shahzad31

LGTM !!

justinkambic · 2020-09-08T12:52:12Z

@elasticmachine merge upstream

kibanamachine · 2020-09-08T14:41:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1a473b3

Build metrics

async chunks size

id	value	diff	baseline
uptime	1.6MB	+1.0KB	1.6MB

page load bundle size

id	value	diff	baseline
uptime	25.1KB	-59.0B	25.1KB

History

💚 Build #72715 succeeded a76b9a6
💚 Build #72282 succeeded 73f8422
💔 Build #72272 failed cb7b686
💚 Build #72047 succeeded 9dfba1e
💚 Build #71890 succeeded 0374dc3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Remove hashbang and modify router to use ScopedHistory. * Update test to conform to refactored API. * Update test snapshots. * Fix broken type check. * Remove unneeded prop. * Prevent full page reload for breadcrumbs. * Fix outdated test. * Fix type errors. * Add default value for focusConnectorField url param. * Make stringify function support focusFieldConnector empty values. * Avoid unnecessary text in breadcrumb href. * Refresh test snapshot. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Remove hashbang and modify router to use ScopedHistory. * Update test to conform to refactored API. * Update test snapshots. * Fix broken type check. * Remove unneeded prop. * Prevent full page reload for breadcrumbs. * Fix outdated test. * Fix type errors. * Add default value for focusConnectorField url param. * Make stringify function support focusFieldConnector empty values. * Avoid unnecessary text in breadcrumb href. * Refresh test snapshot. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

justinkambic · 2020-09-08T19:36:02Z

Backported to:

7.x/7.10.0 1b93d4e
[7.x] [Uptime] Modify router to use ScopedHistory (#76421) #76956

justinkambic added 3 commits September 1, 2020 14:11

Remove hashbang and modify router to use ScopedHistory.

d6f0801

Update test to conform to refactored API.

6fbd766

Update test snapshots.

8a9b40d

justinkambic added v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 1, 2020

justinkambic requested review from andrewvc, pgayvallet and shahzad31 September 1, 2020 18:36

justinkambic requested a review from a team as a code owner September 1, 2020 18:36

justinkambic self-assigned this Sep 1, 2020

Fix broken type check.

dce1da0

pgayvallet approved these changes Sep 2, 2020

View reviewed changes

shahzad31 reviewed Sep 2, 2020

View reviewed changes

shahzad31 requested changes Sep 2, 2020

View reviewed changes

justinkambic added 3 commits September 2, 2020 08:41

Merge branch 'master' into uptime_hashbang-removal

e11d443

Remove unneeded prop.

c3fa61b

Prevent full page reload for breadcrumbs.

0e4ff0a

justinkambic added 2 commits September 2, 2020 09:57

Fix outdated test.

525d62c

Fix type errors.

0374dc3

Merge branch 'master' into uptime_hashbang-removal

9dfba1e

justinkambic added 3 commits September 3, 2020 08:19

Merge branch 'master' into uptime_hashbang-removal

3c5bbd6

Add default value for focusConnectorField url param.

faceb99

Make stringify function support focusFieldConnector empty values.

6e3a24b

justinkambic added 3 commits September 3, 2020 10:09

Avoid unnecessary text in breadcrumb href.

03dd34d

Merge branch 'uptime_hashbang-removal' of github.com:justinkambic/kib…

cb7b686

…ana into uptime_hashbang-removal

Refresh test snapshot.

73f8422

Merge branch 'master' into uptime_hashbang-removal

a76b9a6

shahzad31 approved these changes Sep 6, 2020

View reviewed changes

Merge branch 'master' into uptime_hashbang-removal

1a473b3

justinkambic merged commit 4afa2d6 into elastic:master Sep 8, 2020

justinkambic mentioned this pull request Sep 8, 2020

[7.x] [Uptime] Modify router to use ScopedHistory (#76421) #76956

Merged

justinkambic deleted the uptime_hashbang-removal branch September 8, 2020 19:36

Conversation

justinkambic commented Sep 1, 2020

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 1, 2020

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

justinkambic Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic commented Sep 2, 2020

Uh oh!

justinkambic commented Sep 2, 2020

Uh oh!

justinkambic commented Sep 2, 2020

Uh oh!

shahzad31 commented Sep 3, 2020

Uh oh!

justinkambic commented Sep 3, 2020

Uh oh!

justinkambic commented Sep 4, 2020

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic commented Sep 8, 2020

Uh oh!

kibanamachine commented Sep 8, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

justinkambic commented Sep 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants