[7.x] [Uptime] Modify router to use ScopedHistory (#76421)#76956
Merged
justinkambic merged 1 commit intoelastic:7.xfrom Sep 8, 2020
Merged
[7.x] [Uptime] Modify router to use ScopedHistory (#76421)#76956justinkambic merged 1 commit intoelastic:7.xfrom
ScopedHistory (#76421)#76956justinkambic merged 1 commit intoelastic:7.xfrom
Conversation
* Remove hashbang and modify router to use ScopedHistory. * Update test to conform to refactored API. * Update test snapshots. * Fix broken type check. * Remove unneeded prop. * Prevent full page reload for breadcrumbs. * Fix outdated test. * Fix type errors. * Add default value for focusConnectorField url param. * Make stringify function support focusFieldConnector empty values. * Avoid unnecessary text in breadcrumb href. * Refresh test snapshot. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x:
ScopedHistory([Uptime] Modify router to useScopedHistory#76421)