Skip to content

Unskip Lens OriginatingApp Breadcrumb test#75714

Merged
ThomThomson merged 2 commits intoelastic:masterfrom
ThomThomson:fix/lensBreadcrumbTest
Aug 24, 2020
Merged

Unskip Lens OriginatingApp Breadcrumb test#75714
ThomThomson merged 2 commits intoelastic:masterfrom
ThomThomson:fix/lensBreadcrumbTest

Conversation

@ThomThomson
Copy link
Copy Markdown
Contributor

Summary

Closes #75694

updates test added in #75470 to work properly with the new document format from #74523.

For maintainers

@ThomThomson ThomThomson added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 v7.10.0 labels Aug 22, 2020
@ThomThomson ThomThomson requested a review from a team August 22, 2020 01:57
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ThomThomson
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DaaaaaaadauLGTM! Codeowner review since the mighty Jenkins already tested

Copy link
Copy Markdown
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was a recent change to the Lens state.

Please remove the release note- this isn't something that is being released

@ThomThomson ThomThomson added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Aug 24, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit f495b7d into elastic:master Aug 24, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Aug 24, 2020
…ic#75714)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test: X-Pack Jest Tests.x-pack/plugins/lens/public/app_plugin - Lens App sets originatingApp breadcrumb when the document title changes

5 participants