Modularize render complete#74504
Merged
streamich merged 9 commits intoelastic:masterfrom Aug 20, 2020
streamich:modularize-render-complete
Merged
Modularize render complete#74504streamich merged 9 commits intoelastic:masterfrom streamich:modularize-render-complete
streamich merged 9 commits intoelastic:masterfrom
streamich:modularize-render-complete
Conversation
This reverts commit 0049c01.
Contributor
|
Is this ready to review? It's unclear what this is about based on the description and tags |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
Hey @wylieconlon, sorry I was on holidays. I uploaded this PR last week to see if build succeeds, but now it is ready for review. I've liked the correct issue in description and will update the tags. |
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
ppisljar
reviewed
Aug 13, 2020
ppisljar
reviewed
Aug 13, 2020
3 tasks
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Aug 20, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, CodeOwner review, tested locally in Chrome, Firefox, MacOs, data-render-complete of Discover works 👍
streamich
added a commit
that referenced
this pull request
Aug 20, 2020
* chore: 🤖 remove unused render-complete logic * feat: 🎸 add render-complete observables to IEmbeddable * Revert "chore: 🤖 remove unused render-complete logic" This reverts commit 0049c01. * refactor: 💡 rename render complete "helper" to "listener" * feat: 🎸 add render complete dispatcher to embeddable * refactor: 💡 move data-title setup to Embeddable * refactor: 💡 move embeddable data-title setting to render-compl Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71848
VisualizeEmbeddableintoEmbeddableandRenderCompleteDispatcher. This allows us to add render-complete logic to any embeddable. And because it is separated out intoRenderCompleteDispatcherwe can also reuse that logic outside of embeddables.P.S. Render-complete logic is needed for reporting and functional tests, so they know elements on the page have loaded and finished rendering.