[Security Solution] Fixes scroll issues related to the sticky header#74062
Merged
andrew-goldstein merged 12 commits intoelastic:masterfrom Aug 4, 2020
Merged
[Security Solution] Fixes scroll issues related to the sticky header#74062andrew-goldstein merged 12 commits intoelastic:masterfrom
andrew-goldstein merged 12 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](elastic#73882). With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.) Fixes: elastic#73882 Desk tested in: - Chrome `84.0.4147.105` - Firefox `79.0` - Safari `13.1.2`
e0e7774 to
fff56c7
Compare
x-pack/plugins/security_solution/public/common/components/header_global/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/components/header_global/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/hooks/use_global_header_portal.tsx
Show resolved
Hide resolved
patrykkopycinski
approved these changes
Aug 3, 2020
Contributor
patrykkopycinski
left a comment
There was a problem hiding this comment.
we have paired together on the zoom and tested the solution and LGTM! Thank you @andrew-goldstein for taking care of that issue 💪 🟢 merge, backport and enjoy your 🌴
Contributor
Author
|
Thanks for your skill and help with this PR @patrykkopycinski! |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Aug 4, 2020
…lastic#74062) ## [Security Solution] Fixes scroll issues related to the sticky header Fixes scrolling issues related to the sticky header. The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](elastic#73882). With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.) Fixes: elastic#73882 ## Desk testing Desk tested in: - Chrome `84.0.4147.105` - Firefox `79.0` - Safari `13.1.2`
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Aug 4, 2020
…lastic#74062) ## [Security Solution] Fixes scroll issues related to the sticky header Fixes scrolling issues related to the sticky header. The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](elastic#73882). With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.) Fixes: elastic#73882 ## Desk testing Desk tested in: - Chrome `84.0.4147.105` - Firefox `79.0` - Safari `13.1.2`
andrew-goldstein
added a commit
that referenced
this pull request
Aug 4, 2020
…74062) (#74208) ## [Security Solution] Fixes scroll issues related to the sticky header Fixes scrolling issues related to the sticky header. The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](#73882). With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.) Fixes: #73882 ## Desk testing Desk tested in: - Chrome `84.0.4147.105` - Firefox `79.0` - Safari `13.1.2`
andrew-goldstein
added a commit
that referenced
this pull request
Aug 4, 2020
…74062) (#74207) ## [Security Solution] Fixes scroll issues related to the sticky header Fixes scrolling issues related to the sticky header. The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](#73882). With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.) Fixes: #73882 ## Desk testing Desk tested in: - Chrome `84.0.4147.105` - Firefox `79.0` - Safari `13.1.2`
1 task
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Security Solution] Fixes scroll issues related to the sticky header
Fixes scrolling issues related to the sticky header.
The Security solution hid the app navigation links (e.g.
Overview,Detections,Hosts...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent7.9BCs, sometimes this created issues while scrolling.With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)
Fixes: #73882
Desk testing
Desk tested in:
84.0.4147.10579.013.1.2