Skip to content

[7.9] [Security Solution] Fixes scroll issues related to the sticky header (#74062)#74208

Merged
andrew-goldstein merged 1 commit intoelastic:7.9from
andrew-goldstein:backport/7.9/pr-74062
Aug 4, 2020
Merged

[7.9] [Security Solution] Fixes scroll issues related to the sticky header (#74062)#74208
andrew-goldstein merged 1 commit intoelastic:7.9from
andrew-goldstein:backport/7.9/pr-74062

Conversation

@andrew-goldstein
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.9:

…lastic#74062)

## [Security Solution] Fixes scroll issues related to the sticky header

Fixes scrolling issues related to the sticky header.

The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](elastic#73882).

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: elastic#73882

## Desk testing

Desk tested in:
- Chrome `84.0.4147.105`
- Firefox `79.0`
- Safari `13.1.2`
@andrew-goldstein andrew-goldstein added the backport This PR is a backport of another PR label Aug 4, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1057 -8 1065

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrew-goldstein andrew-goldstein merged commit 2ac4757 into elastic:7.9 Aug 4, 2020
@andrew-goldstein andrew-goldstein deleted the backport/7.9/pr-74062 branch August 4, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants