[ML] Fix initial plugin's bundle size#74047
Merged
darnautov merged 10 commits intoelastic:masterfrom Aug 5, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
approved these changes
Aug 5, 2020
Member
jgowdyelastic
left a comment
There was a problem hiding this comment.
Added a couple of questions.
Tested and LGTM
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Aug 5, 2020
* [ML] use dynamic imports * [ML] fix react-use imports * [ML] change embeddables imports * [ML] embeddable exports * [ML] move SCSS import * [ML] management page styles * [ML] refactor with types and constants files * [ML] move declarations
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Aug 5, 2020
* [ML] use dynamic imports * [ML] fix react-use imports * [ML] change embeddables imports * [ML] embeddable exports * [ML] move SCSS import * [ML] management page styles * [ML] refactor with types and constants files * [ML] move declarations
mdefazio
reviewed
Aug 5, 2020
Contributor
mdefazio
left a comment
There was a problem hiding this comment.
Change requested on switching the import in the jobs_list
Comment on lines
+2
to
+4
| #kibanaManagementMLSection { | ||
| @import 'components/index'; | ||
| } |
Contributor
There was a problem hiding this comment.
Can we switch this so it uses a three-letter prefix on the classes, instead of nesting within an id?
Contributor
Author
There was a problem hiding this comment.
Hi @mdefazio! Sorry, I already merged this one, but the point of this PR was to rearrange some imports to reduce the bundle size we deliver during kibana loading. We definitely need to revisit our SCSS files, I believe it deserves a dedicated PR.
darnautov
added a commit
that referenced
this pull request
Aug 5, 2020
* [ML] use dynamic imports * [ML] fix react-use imports * [ML] change embeddables imports * [ML] embeddable exports * [ML] move SCSS import * [ML] management page styles * [ML] refactor with types and constants files * [ML] move declarations
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 5, 2020
* master: (154 commits) [ML] Fix initial plugin's bundle size (elastic#74047) [Ingest Manager] prevent crash on unhandled rejection from setupIngestManager (elastic#74300) [Logs UI] Correct trial period duration in anomaly splash screen (elastic#74249) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces ML plugin initial bundle size. There is still room for improvement, e.g. we can change
lodashandsemverimports, some utils functions, but this PR already makes it significantly better ( 4.3MB -> 499KB).Checklist