[Monitoring] Ensure setup mode works on cloud but only for alerts by chrisronline · Pull Request #73127 · elastic/kibana

chrisronline · 2020-07-23T19:37:00Z

Resolves #72511

We need to change our setup mode works by adding a concept of features where we can control which feature shows up in cloud or not (or use any criteria really).

I also added a basic functional test to ensure cloud users do not see the metricbeat migration feature, but am currently unable to add more tests around if they can properly see alerting. I'll continue to look into it but I'm OK with this going in without that.

Testing

You'll need to manually set our cloud checks to true to get into the right state, but after that, you'll be able to just enter setup mode and ensure you don't see metricbeat migration options.

I think it's one check and it's here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/plugin.ts#L89

…ode_cloud

chrisronline · 2020-07-28T18:27:04Z

@elasticmachine merge upstream

chrisronline · 2020-07-29T15:27:27Z

@elasticmachine merge upstream

elasticmachine · 2020-07-29T15:27:57Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

x-pack/plugins/monitoring/public/lib/setup_mode.tsx

x-pack/test/functional/services/monitoring/setup_mode.js

igoristic

Just couple of suggestions, but other than that I think it looks good 👍

…ode_cloud

chrisronline · 2020-08-03T13:12:43Z

@elasticmachine merge upstream

igoristic

Looks good! Nice work 👍

chrisronline · 2020-08-03T19:03:50Z

@elasticmachine merge upstream

chrisronline · 2020-08-03T19:03:59Z

Let's just make sure this test is good to go and then I'll merge

chrisronline · 2020-08-04T13:33:19Z

@elasticmachine merge upstream

kibanamachine · 2020-08-04T15:29:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 26ce20b

Build metrics

async chunks size

id	value	diff	baseline
monitoring	1.1MB	+1.5KB	1.1MB

page load bundle size

id	value	diff	baseline
monitoring	295.4KB	+282.0B	295.1KB

History

💛 Build #66192 was flaky 21862fc
💛 Build #66075 was flaky e564886
💚 Build #65922 succeeded a1d1802
💚 Build #65886 succeeded 61183cf
💔 Build #65878 failed f9ed8f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…astic#73127) * Ensure setup mode works on cloud but only for alerts * Update snapshot * Update translations * Restructure tests to understand the failure better * PR feedback * Backwards, whoops * Remove commented out code Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/public/components/apm/instances/instances.js

…3127) (#74284) * Ensure setup mode works on cloud but only for alerts * Update snapshot * Update translations * Restructure tests to understand the failure better * PR feedback * Backwards, whoops * Remove commented out code Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/public/components/apm/instances/instances.js

…ts (#73127) (#74282) * [Monitoring] Ensure setup mode works on cloud but only for alerts (#73127) * Ensure setup mode works on cloud but only for alerts * Update snapshot * Update translations * Restructure tests to understand the failure better * PR feedback * Backwards, whoops * Remove commented out code Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/public/components/apm/instances/instances.js * Remove this

chrisronline · 2020-08-04T19:50:09Z

Backport:

7.9: 56a3ef4
7.x: 58f41ab

* master: (74 commits) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) [kbn/optimizer] remove unused modules (elastic#74195) [CI] Add pipeline task queue framework and merge workers into one (elastic#71268) Using msearch for tree api endpoint (elastic#73813) ...

* master: (115 commits) [Logs UI] Correct trial period duration in anomaly splash screen (elastic#74249) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) [kbn/optimizer] remove unused modules (elastic#74195) [CI] Add pipeline task queue framework and merge workers into one (elastic#71268) ...

* master: (154 commits) [ML] Fix initial plugin's bundle size (elastic#74047) [Ingest Manager] prevent crash on unhandled rejection from setupIngestManager (elastic#74300) [Logs UI] Correct trial period duration in anomaly splash screen (elastic#74249) [Discover] Inline noWhiteSpace function (elastic#74331) [DOCS] Add Observability topic (elastic#73041) skip flaky suite (elastic#74327) [Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (elastic#74317) [Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (elastic#74250) Fixed Alert details does not update page title and breadcrumb (elastic#74214) [src/dev/build] build Kibana Platform bundles from source (elastic#73591) [Reporting] Shorten asset path to help CLI FS Watcher (elastic#74185) Fix TMS not loaded in legacy maps (elastic#73570) [Security Solution] styling for notes' panel (elastic#74274) [Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (elastic#74268) Make the actions plugin support generics (elastic#71439) [Security Solution] Keep original note creator (elastic#74203) [CI] Fix xpack kibana build dir in xpack visual regression script [CI] Fix baseline_capture job by adding parallel process number back [Monitoring] Ensure setup mode works on cloud but only for alerts (elastic#73127) [Maps] Custom color ramps should show correctly on the map for mvt layers (elastic#74169) ...

chrisronline added 4 commits July 23, 2020 15:35

Ensure setup mode works on cloud but only for alerts

758743b

Update snapshot

2efdc72

Merge remote-tracking branch 'elastic/master' into monitoring/setup_m…

7dc2428

…ode_cloud

Update translations

b3a2653

Merge branch 'master' into monitoring/setup_mode_cloud

01ac04f

chrisronline self-assigned this Jul 29, 2020

chrisronline added release_note:fix review Team:Monitoring Stack Monitoring team v7.10.0 v7.11.0 v8.0.0 labels Jul 29, 2020

Merge branch 'master' into monitoring/setup_mode_cloud

dc58779

chrisronline marked this pull request as ready for review July 29, 2020 15:27

chrisronline requested a review from a team July 29, 2020 15:27

Restructure tests to understand the failure better

a7084fd

chrisronline added this to the Stack Monitoring UI 7.10 milestone Jul 30, 2020

igoristic reviewed Jul 30, 2020

View reviewed changes

x-pack/plugins/monitoring/public/lib/setup_mode.tsx Show resolved Hide resolved

igoristic reviewed Jul 30, 2020

View reviewed changes

x-pack/test/functional/services/monitoring/setup_mode.js Outdated Show resolved Hide resolved

igoristic approved these changes Jul 30, 2020

View reviewed changes

chrisronline added 4 commits July 31, 2020 14:44

PR feedback

27d01eb

Merge remote-tracking branch 'elastic/master' into monitoring/setup_m…

f9ed8f7

…ode_cloud

Backwards, whoops

61183cf

Remove commented out code

a1d1802

chrisronline requested a review from igoristic July 31, 2020 21:26

Merge branch 'master' into monitoring/setup_mode_cloud

e564886

igoristic approved these changes Aug 3, 2020

View reviewed changes

Merge branch 'master' into monitoring/setup_mode_cloud

21862fc

Merge branch 'master' into monitoring/setup_mode_cloud

26ce20b

chrisronline merged commit de22caa into elastic:master Aug 4, 2020

chrisronline deleted the monitoring/setup_mode_cloud branch August 4, 2020 17:32

This was referenced Aug 4, 2020

[7.x] [Monitoring] Ensure setup mode works on cloud but only for alerts (#73127) #74282

Merged

[7.9] [Monitoring] Ensure setup mode works on cloud but only for alerts (#73127) #74284

Merged

spalger mentioned this pull request Aug 5, 2020

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/setup/metricbeat_migration·js - Monitoring app Setup mode metricbeat migration setup mode btn should exist #74327

Open

chrisronline mentioned this pull request Oct 13, 2020

[Monitoring] Fix bug with setup mode appearing on pages it shouldn't #80343

Merged

chrisronline mentioned this pull request Dec 14, 2020

[Stack Monitoring] [Test Scenario] Out of the box alerting #85841

Closed

23 tasks

chrisronline mentioned this pull request Mar 1, 2021

[Stack Monitoring] [Test Scenario] Out of the box alerting #93072

Closed

24 tasks

simianhacker mentioned this pull request Apr 29, 2021

[Stack Monitoring] [Test Scenario] Out of the box alerting #98765

Closed

24 tasks

neptunian mentioned this pull request Jul 6, 2021

[Stack Monitoring] [Test Scenario] Out of the box alerting #104440

Closed

35 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitoring] Ensure setup mode works on cloud but only for alerts#73127

[Monitoring] Ensure setup mode works on cloud but only for alerts#73127
chrisronline merged 14 commits intoelastic:masterfrom
chrisronline:monitoring/setup_mode_cloud

chrisronline commented Jul 23, 2020 •

edited

Loading

Uh oh!

chrisronline commented Jul 28, 2020

Uh oh!

chrisronline commented Jul 29, 2020

Uh oh!

elasticmachine commented Jul 29, 2020

Uh oh!

Uh oh!

Uh oh!

igoristic left a comment

Uh oh!

chrisronline commented Aug 3, 2020

Uh oh!

igoristic left a comment

Uh oh!

chrisronline commented Aug 3, 2020

Uh oh!

chrisronline commented Aug 3, 2020

Uh oh!

chrisronline commented Aug 4, 2020

Uh oh!

kibanamachine commented Aug 4, 2020

Uh oh!

chrisronline commented Aug 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chrisronline commented Jul 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

chrisronline commented Jul 28, 2020

Uh oh!

chrisronline commented Jul 29, 2020

Uh oh!

elasticmachine commented Jul 29, 2020

Uh oh!

Uh oh!

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline commented Aug 3, 2020

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline commented Aug 3, 2020

Uh oh!

chrisronline commented Aug 3, 2020

Uh oh!

chrisronline commented Aug 4, 2020

Uh oh!

kibanamachine commented Aug 4, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

chrisronline commented Aug 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chrisronline commented Jul 23, 2020 •

edited

Loading